Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236648: javadoc warning on Text::tabSizeProperty method #78

Closed
wants to merge 1 commit into from

Conversation

swpalmer
Copy link
Collaborator

@swpalmer swpalmer commented Jan 6, 2020

Implemented suggested fix to address javadoc warning.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8236648: javadoc warning on Text::tabSizeProperty method

Approvers

  • Kevin Rushforth (kcr - Reviewer)

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2020

👋 Welcome back swpalmer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr Ready for review label Jan 6, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is a low-impact change so one reviewer will suffice.

@openjdk openjdk bot removed the rfr Ready for review label Jan 6, 2020
@openjdk
Copy link

openjdk bot commented Jan 6, 2020

@swpalmer This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8236648: javadoc warning on Text::tabSizeProperty method

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Jan 6, 2020
@swpalmer
Copy link
Collaborator Author

swpalmer commented Jan 6, 2020

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Jan 6, 2020
@openjdk
Copy link

openjdk bot commented Jan 6, 2020

@swpalmer
Your change (at version bd81a90) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Jan 6, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Ready to sponsor ready Ready to be integrated labels Jan 6, 2020
@openjdk
Copy link

openjdk bot commented Jan 6, 2020

@kevinrushforth @swpalmer The following commits have been pushed to master since your change was applied:

  • 587f195: 8234474: [macos 10.15] Crash in file dialog in sandbox mode
  • f1108b0: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

Your commit was automatically rebased without conflicts.

Pushed as commit e0b45f8.

@mlbridge
Copy link

mlbridge bot commented Jan 6, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: e0b45f8
Author: Scott Palmer <swpalmer at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-01-06 23:27:43 +0000
URL: https://git.openjdk.java.net/jfx/commit/e0b45f8d

8236648: javadoc warning on Text::tabSizeProperty method

Reviewed-by: kcr

! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants