-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8236648: javadoc warning on Text::tabSizeProperty method #78
Conversation
👋 Welcome back swpalmer! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This is a low-impact change so one reviewer will suffice.
@swpalmer This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@kevinrushforth @swpalmer The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit e0b45f8. |
Mailing list message from Kevin Rushforth on openjfx-dev: Changeset: e0b45f8 8236648: javadoc warning on Text::tabSizeProperty method Reviewed-by: kcr ! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java |
Implemented suggested fix to address javadoc warning.
Progress
Issue
JDK-8236648: javadoc warning on Text::tabSizeProperty method
Approvers