8255015: Inconsistent illumination of 3D shape by PointLight

[andreas-heger]

The inconsistent illumination happens on Macs with retina displays only if the 3D shape is placed in a SubScene. The light sources are located with wrong coordinates in sub scenes and this causes a different illumination. The wrong coordinates for the light sources come from the fact that the retina pixel scale factors are not used in a SubScene.

With this pull request, the retina pixel scale factors will be also used in SubScenes and this should resolve the bug
https://bugs.openjdk.java.net/browse/JDK-8255015

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255015: Inconsistent illumination of 3D shape by PointLight

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/530/head:pull/530
$ git checkout pull/530

Update a local copy of the PR:
$ git checkout pull/530
$ git pull https://git.openjdk.java.net/jfx pull/530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 530

View PR using the GUI difftool:
$ git pr show -t 530

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/530.diff

[bridgekeeper]

👋 Welcome back andreas-heger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @andreas-heger a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master ca250364aae7a4e071d307ac1091c22776cf9a38
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[mlbridge]

Webrevs

• 01: Full - Incremental (ca250364)
• 00: Full (66b361a0)