Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes #303

Closed
wants to merge 11 commits into from
+91 −61
Closed

8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes #303

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
05c2c88
8231601: Update CONTRIBUTING.md to clarify process for contributing f…
kevinrushforth Sep 12, 2020
d46f5d0
Address review comments + additional fixes
kevinrushforth Sep 14, 2020
9840ffe
Address review comments
kevinrushforth Sep 14, 2020
becd269
Fixed URL to WEBKIT-MEDIA-STUBS.md
kevinrushforth Sep 14, 2020
9ee77cf
Address review coments
kevinrushforth Sep 18, 2020
1c41e9c
Merge branch 'master' into 8231601-contributing
kevinrushforth Dec 16, 2021
47f51a3
Minor updates to address pending review comments that I did last year…
kevinrushforth Oct 12, 2020
9d3820a
More review comments
kevinrushforth Dec 17, 2021
200e2f3
Address more review comments
kevinrushforth Dec 17, 2021
b135ee6
Minor updates
kevinrushforth Dec 17, 2021
5bd5204
Address review comments
kevinrushforth Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
@@ -210,7 +210,7 @@ If you are changing anything that might possibly affect rendering, you should ru
bash ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true all test
```

If you don't build WebKit (using the `-PCOMPILE_WEBKIT=true` option), you are likely to get test failures when running the web tests. See the [Web Testing](https://github.com/kevinrushforth/jfx/blob/master/WEBKIT-MEDIA-STUBS.md) page for information on how to address this.
If you don't build WebKit (using the `-PCOMPILE_WEBKIT=true` option), you are likely to get test failures when running the web tests. See the [Web Testing](WEBKIT-MEDIA-STUBS.md) page for information on how to address this.

Even more documentation on OpenJFX projects and its build system can be found on the
[OpenJFX Wiki](https://wiki.openjdk.java.net/display/OpenJFX/).