8150669: C1 intrinsic for Class.isPrimitive

[dongbohe]

Hi,

Please review this backport. The original purpose is to backport fix for JDK-8239477. But this depends on fix for JDK-8150669 & JDK-8233019.

Performed full jtreg test both on x86_64-linux-gnu and aarch64-linux-gnu platforms.

This PR has been reviewed by Paul and approved before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-August/014155.html

Follow-up fix JDK-8233019 is planned to be backported as well.

(I made this PR on behalf of fyang)

Thanks,
hedongbo

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8150669: C1 intrinsic for Class.isPrimitive

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.org/jdk8u-dev pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/37.diff

[bridgekeeper]

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (c14c86c2)
• 00: Full (3418e09e)

[dongbohe]

/reviewer add phh

[openjdk]

@dongbohe Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[dongbohe]

/reviewer credit phh

[openjdk]

@dongbohe
Reviewer phh successfully credited.

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[dongbohe]

/open

[openjdk]

@dongbohe This pull request is now open

[phohensee]

Lgtm.

[openjdk]

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8150669: C1 intrinsic for Class.isPrimitive

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 6e8292f: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ce73401: 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
• a3c0ed2: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation
• 1b4f32d: 8173361: various crashes in JvmtiExport::post_compiled_method_load
• cf6b628: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dongbohe]

Got the push approval.
/integrate

[openjdk]

@dongbohe
Your change (at version c14c86c) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit eeef4de.
Since your change was applied there have been 5 commits pushed to the master branch:

• 6e8292f: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ce73401: 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
• a3c0ed2: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation
• 1b4f32d: 8173361: various crashes in JvmtiExport::post_compiled_method_load
• cf6b628: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @dongbohe Pushed as commit eeef4de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.