Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk18 Public archive

8280441: Missing "classpath exception" in several files from jdk.httpserver #111

Closed
wants to merge 1 commit into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jan 21, 2022

This change adds the classpath exception to the copyright header of the files in question. As source files, they should have both the GPL and the classpath exception.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280441: Missing "classpath exception" in several files from jdk.httpserver

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.java.net/jdk18 pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/111.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2022

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.java.net label Jan 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2022

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1–P5 doc bugs are okay to integrate in JDK 18 RDP2, I think fixes copyright header are in the same bucket.

@FrauBoes FrauBoes changed the title 8280441: "classpath exception" in several files from jdk.httpserver 8280441: Missing "classpath exception" in several files from jdk.httpserver Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280441: Missing "classpath exception" in several files from jdk.httpserver

Reviewed-by: alanb, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2022
@FrauBoes
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2022

Going to push as commit ead9fec.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7d2ef9d: 8279179: Update nroff pages in JDK 18 before RC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2022
@openjdk openjdk bot closed this Jan 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2022
@openjdk
Copy link

openjdk bot commented Jan 24, 2022

@FrauBoes Pushed as commit ead9fec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated net net-dev@openjdk.java.net
Development

Successfully merging this pull request may close these issues.

None yet

3 participants