-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276025: Hotspot's libsvml.so may conflict with user dependency #250
Conversation
👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@vnkozlov Could you please review and approve. This is a clean backport but somehow the bot hasn't applied the clean label. |
@sviswa7 You need to integrate it first as you did for 8273450. |
@vnkozlov Thanks, I followed the same steps as for 8273450. (https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix) |
Hmm. In 8273450 I see Bot's comment: But for some reasons current changes are not treated as clean by Bot: It asked for review. Okay I will add approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean backport.
@sviswa7 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Testing passed. |
Thanks a lot @vnkozlov. |
/sponsor |
Going to push as commit 3e349b4. |
I pushed closed part too. |
Clean backport to fix the conflicts with libsvml.so distributed with Intel's MKL library.
Best Regards,
Sandhya
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/250/head:pull/250
$ git checkout pull/250
Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.java.net/jdk17u pull/250/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 250
View PR using the GUI difftool:
$ git pr show -t 250
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/250.diff