Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT #16

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 20, 2021

A clean backport for parity with Oracle 17.0.3.

This bug could potentially cause unexpected and intermittent failures that would be difficult to find.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/16.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 769f14db847813f5a3601e9ec21e6cadbd99ee96 8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT Dec 20, 2021
@openjdk
Copy link

openjdk bot commented Dec 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 20, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

Going to push as commit db0b611.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 7554d8c: 8278020: ~13% variation in Renaissance-Scrabble
  • 744d785: 8279225: [arm32] C1 longs comparison operation destroys argument registers
  • 3de6b2c: 8266490: Extend the OSContainer API to support the pids controller of cgroups
  • 3d3533a: 8279379: GHA: Print tests that are in error
  • 5ea822c: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
  • e54e3c4: 8278627: Shenandoah: TestHeapDump test failed
  • 3b5fc8c: 8278824: Uneven work distribution when scanning heap roots in G1
  • de2e289: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d
  • 4a188e9: 8277919: OldObjectSample event causing bloat in the class constant pool in JFR recording
  • ca59b64: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for
  • ... and 37 more: https://git.openjdk.java.net/jdk17u-dev/compare/5ea8f4835da08623c5c03983aab10382db2b95a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2022
@openjdk openjdk bot closed this Jan 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@zhengyu123 Pushed as commit db0b611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

MattAlp added a commit to DataDog/openjdk-jdk17 that referenced this pull request Feb 26, 2025
MattAlp added a commit to DataDog/openjdk-jdk17 that referenced this pull request Feb 26, 2025
MattAlp added a commit to DataDog/openjdk-jdk17 that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant