Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16u Public archive

8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags #74

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Mar 4, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/74/head:pull/74
$ git checkout pull/74

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2021

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0785147460934ee2aa413ab7872837094824bd3d 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags

Use -march=i686 instead of -march=i586 if -fcf-protection is passed to the build as CMOV is required

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2021

Webrevs

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@gnu-andrew Pushed as commit 189fe43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew gnu-andrew deleted the backport-JDK-8259949 branch March 4, 2021 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant