-
Notifications
You must be signed in to change notification settings - Fork 30
8274840: Update OS detection code to recognize Windows 11 #115
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@omikhaltsova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@omikhaltsova |
/sponsor |
Going to push as commit 5075dec.
Your commit was automatically rebased without conflicts. |
@yan-too @omikhaltsova Pushed as commit 5075dec. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8274840 to jdk15u for parity with jdk11u.
The original patch applied cleanly.
Tested with a simple test printing OS version on Windows 11 and 10:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/115/head:pull/115
$ git checkout pull/115
Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/115/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 115
View PR using the GUI difftool:
$ git pr show -t 115
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/115.diff