Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8278851: Correct signer logic for jars signed with multiple digest algorithms #345

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 28, 2022

I'd like to backport it for parity with major releases.
Version from 15u applied with only old copyright change in one file. All security tests run OK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278851: Correct signer logic for jars signed with multiple digest algorithms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/345/head:pull/345
$ git checkout pull/345

Update a local copy of the PR:
$ git checkout pull/345
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 345

View PR using the GUI difftool:
$ git pr show -t 345

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/345.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 8278851: Correct signer logic for jars signed with multiple digest algorithms Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 28, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278851: Correct signer logic for jars signed with multiple digest algorithms

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Apr 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

Going to push as commit 80d7902.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2022
@openjdk openjdk bot closed this Apr 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@yan-too Pushed as commit 80d7902.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8278851 branch April 28, 2022 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants