Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233760: Result of BigDecimal.toString throws overflow exception on new BigDecimal(str) #8905

Closed
wants to merge 2 commits into from
+44 −47
Closed

8233760: Result of BigDecimal.toString throws overflow exception on new BigDecimal(str) #8905

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82cece
8233760: Result of BigDecimal.toString throws overflow exception on n…
rgiulietti May 26, 2022
2a25c35
8233760: Result of BigDecimal.toString throws overflow exception on n…
rgiulietti May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion test/jdk/java/math/BigDecimal/StringConstructor.java
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@
* @library /test/lib
* @build jdk.test.lib.RandomFactory
* @run main StringConstructor
* @bug 4103117 4331084 4488017 4490929 6255285 6268365 8074460 8078672
* @bug 4103117 4331084 4488017 4490929 6255285 6268365 8074460 8078672 8233760
* @summary Tests the BigDecimal string constructor (use -Dseed=X to set PRNG seed).
* @key randomness
*/
@@ -70,6 +70,16 @@ public static void main(String[] args) throws Exception {
leadingExponentZeroTest();
nonAsciiZeroTest();

/* These BigDecimals produce a string with an exponent > Integer.MAX_VALUE */
roundtripWithAbnormalExponent(BigDecimal.valueOf(10, Integer.MIN_VALUE));
roundtripWithAbnormalExponent(BigDecimal.valueOf(Long.MIN_VALUE, Integer.MIN_VALUE));
roundtripWithAbnormalExponent(new BigDecimal(new BigInteger("1" + "0".repeat(100)), Integer.MIN_VALUE));

/* These Strings have an exponent > Integer.MAX_VALUE */
roundtripWithAbnormalExponent("1.0E+2147483649");
roundtripWithAbnormalExponent("-9.223372036854775808E+2147483666");
roundtripWithAbnormalExponent("1.0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000E+2147483748");

// Roundtrip tests
Random random = RandomFactory.getRandom();
for (int i=0; i<100; i++) {
@@ -94,6 +104,17 @@ public static void main(String[] args) throws Exception {
}
}

private static void roundtripWithAbnormalExponent(BigDecimal bd) {
if (!bd.equals(new BigDecimal(bd.toString()))) {
throw new RuntimeException("Abnormal exponent roundtrip failure");
}
}

private static void roundtripWithAbnormalExponent(String s) {
if (!s.equals(new BigDecimal(s).toString())) {
throw new RuntimeException("Abnormal exponent roundtrip failure");
}
}

/*
* Verify precision is set properly if the significand has