Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider #8870

Closed
wants to merge 2 commits into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented May 24, 2022

Please review this fix to the XML Signature implementation to check for null or missing DSA parameters and throw a MarshalException before trying to create a DSA public key from its XML encoding. This will allow the code to fail earlier and not depend on the underlying provider to detect illegal or missing parameters.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8870/head:pull/8870
$ git checkout pull/8870

Update a local copy of the PR:
$ git checkout pull/8870
$ git pull https://git.openjdk.java.net/jdk pull/8870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8870

View PR using the GUI difftool:
$ git pr show -t 8870

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8870.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2022

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@seanjmullan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 24, 2022
@mlbridge
Copy link

mlbridge bot commented May 24, 2022

Webrevs

@seanjmullan seanjmullan changed the title 8287246: Check for required DSA parameters instead of letting KeyFactory provi… 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider May 24, 2022
Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented May 25, 2022

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 7156f98: 8279513: jdk/javadoc/doclet/testDocletExample/TestDocletExample.java fails after 8278795
  • f786e2a: 8284037: Snippet-files subdirectory not automatically detected when in unnamed package
  • c674348: 8263075: C2: simplify anti-dependence check in PhaseCFG::implicit_null_check()
  • 0b3d409: 8261768: SelfDestructTimer should accept seconds
  • bc0379e: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
  • 0b8dd4a: 8284966: Update SourceVersion.RELEASE_19 description for language changes
  • e990fec: 8287089: G1CollectedHeap::is_in_cset() can be const methods
  • 81d7eaf: 8287104: AddressChangeListener thread inherits CCL and can cause memory leak for webapp-servers
  • 796494d: 8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
  • e534c13: 8286398: Address possibly lossy conversions in jdk.internal.le
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/8f0eb5d40178b49fa69a623d057ca00846526319...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2022
@seanjmullan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 26, 2022

Going to push as commit f235955.
Since your change was applied there have been 38 commits pushed to the master branch:

  • f58c9a6: 8287244: Add bound check in indexed memory access var handle
  • f710393: 8257810: Only First page are printed in JTable.scrollRectToVisible
  • 704b9a6: 8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller
  • 94811c0: 8286960: Test serviceability/jvmti/vthread/SuspendResume2 crashed: missing ThreadsListHandle in calling context
  • 3d6d7b7: 8287338: tools/javac/api/snippets/TestJavaxToolsSnippets.java failing tier1 on all platforms
  • 7156f98: 8279513: jdk/javadoc/doclet/testDocletExample/TestDocletExample.java fails after 8278795
  • f786e2a: 8284037: Snippet-files subdirectory not automatically detected when in unnamed package
  • c674348: 8263075: C2: simplify anti-dependence check in PhaseCFG::implicit_null_check()
  • 0b3d409: 8261768: SelfDestructTimer should accept seconds
  • bc0379e: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/8f0eb5d40178b49fa69a623d057ca00846526319...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2022
@openjdk openjdk bot closed this May 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2022
@openjdk
Copy link

openjdk bot commented May 26, 2022

@seanjmullan Pushed as commit f235955.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

2 participants