Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287139: aarch64 intrinsic for unsignedMultiplyHigh #8840

Closed
wants to merge 2 commits into from
+17 −1
Closed

8287139: aarch64 intrinsic for unsignedMultiplyHigh #8840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1490515
8287139: aarch64 intrinsic for unsignedMultiplyHigh
rgiulietti May 23, 2022
07226ed
8287139: aarch64 intrinsic for unsignedMultiplyHigh
rgiulietti May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/hotspot/cpu/aarch64/aarch64.ad
View file
Original file line number Diff line number Diff line change
@@ -11132,7 +11132,7 @@ instruct mulHiL_rReg(iRegLNoSp dst, iRegL src1, iRegL src2, rFlagsReg cr)
match(Set dst (MulHiL src1 src2));

ins_cost(INSN_COST * 7);
format %{ "smulh $dst, $src1, $src2, \t# mulhi" %}
format %{ "smulh $dst, $src1, $src2\t# mulhi" %}

ins_encode %{
__ smulh(as_Register($dst$$reg),
@@ -11143,6 +11143,22 @@ instruct mulHiL_rReg(iRegLNoSp dst, iRegL src1, iRegL src2, rFlagsReg cr)
ins_pipe(lmul_reg_reg);
%}

instruct umulHiL_rReg(iRegLNoSp dst, iRegL src1, iRegL src2, rFlagsReg cr)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rFlagsReg cr is not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I noticed, but since there are many more unused rFlagsReg cr in the file and since I don't know its semantics, I prefer to just leave it as it is.

%{
match(Set dst (UMulHiL src1 src2));

ins_cost(INSN_COST * 7);
format %{ "umulh $dst, $src1, $src2\t# umulhi" %}

ins_encode %{
__ umulh(as_Register($dst$$reg),
as_Register($src1$$reg),
as_Register($src2$$reg));
%}

ins_pipe(lmul_reg_reg);
%}

// Combined Integer Multiply & Add/Sub

instruct maddI(iRegINoSp dst, iRegIorL2I src1, iRegIorL2I src2, iRegIorL2I src3) %{