Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286729: G1: Calculation to fit in optional region in remaining pause time wrong #8722

Closed
wants to merge 1 commit into from
+5 −4
Closed

8286729: G1: Calculation to fit in optional region in remaining pause time wrong #8722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/hotspot/share/gc/g1/g1Policy.cpp
View file
Original file line number Diff line number Diff line change
@@ -1393,13 +1393,13 @@ void G1Policy::calculate_optional_collection_set_regions(G1CollectionSetCandidat
assert(_g1h->collector_state()->in_mixed_phase(), "Should only be called in mixed phase");

num_optional_regions = 0;
double prediction_ms = 0;
double total_prediction_ms = 0.0;
uint candidate_idx = candidates->cur_idx();

HeapRegion* r = candidates->at(candidate_idx);
while (num_optional_regions < max_optional_regions) {
assert(r != NULL, "Region must exist");
prediction_ms += predict_region_total_time_ms(r, false);
double prediction_ms = predict_region_total_time_ms(r, false);

if (prediction_ms > time_remaining_ms) {
log_debug(gc, ergo, cset)("Prediction %.3fms for region %u does not fit remaining time: %.3fms.",
@@ -1408,13 +1408,14 @@ void G1Policy::calculate_optional_collection_set_regions(G1CollectionSetCandidat
}
// This region will be included in the next optional evacuation.

total_prediction_ms += prediction_ms;
time_remaining_ms -= prediction_ms;
num_optional_regions++;
r = candidates->at(++candidate_idx);
}

log_debug(gc, ergo, cset)("Prepared %u regions out of %u for optional evacuation. Predicted time: %.3fms",
num_optional_regions, max_optional_regions, prediction_ms);
log_debug(gc, ergo, cset)("Prepared %u regions out of %u for optional evacuation. Total predicted time: %.3fms",
num_optional_regions, max_optional_regions, total_prediction_ms);
}

// Number of regions required to store the given number of bytes, taking