8286628: Remove unused BufferNode::Allocator::flush_free_list

[albertnetymk]

Simple change of removing an unused API.

Test: hotspot_gc

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8286628: Remove unused BufferNode::Allocator::flush_free_list

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8676/head:pull/8676
$ git checkout pull/8676

Update a local copy of the PR:
$ git checkout pull/8676
$ git pull https://git.openjdk.java.net/jdk pull/8676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8676

View PR using the GUI difftool:
$ git pr show -t 8676

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8676.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (28fe8e0a)

[kimbarrett]

I was a bit surprised it isn't used more, but couldn't come up with any
missing uses.

The change violates the Law of Demeter, but that's pretty much par for HotSpot
code. (I think it's a useful design rule and yet often fail to follow it
myself.) Just support of whitebox testing isn't a great rationale for a public
API function if it can be done without.

So looks good.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286628: Remove unused BufferNode::Allocator::flush_free_list

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 0be1f3e: 8286689: (se) Adjusting to select timeout after EINTR messed up after JDK-8286378
• 6a1b098: 8278039: Code completion not woking after some statements such as "if" or "while"
• 11fa03f: 8282160: JShell circularly-required classes cannot be defined
• d5ae383: 8286117: Remove unnecessary indirection and unused code in UL
• c3bade2: 8286623: Bundle zlib by default with JDK on macos aarch64
• 617ef54: 8286647: JFR: Build failure when C1 or C2 is disabled after JDK-8282420
• 369611e: 8286677: [BACKOUT] (fc) Tune FileChannel.transferFrom()
• 4b8a66a: 8286424: GetVersionEx is deprecated
• 986d87d: 8274113: (fc) Tune FileChannel.transferFrom()
• 61cb4b7: 8285951: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase_vm_gc_ref tests
• ... and 33 more: https://git.openjdk.java.net/jdk/compare/89de756ffbefac452c7df559e2a4eb50bf71368b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Lgtm. Same comment as Kim, but I do not think we need to have an extra API just for the test.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 8daf08d.
Since your change was applied there have been 44 commits pushed to the master branch:

• 04df8b7: 8286194: ExecutorShutdown test fails intermittently
• 0be1f3e: 8286689: (se) Adjusting to select timeout after EINTR messed up after JDK-8286378
• 6a1b098: 8278039: Code completion not woking after some statements such as "if" or "while"
• 11fa03f: 8282160: JShell circularly-required classes cannot be defined
• d5ae383: 8286117: Remove unnecessary indirection and unused code in UL
• c3bade2: 8286623: Bundle zlib by default with JDK on macos aarch64
• 617ef54: 8286647: JFR: Build failure when C1 or C2 is disabled after JDK-8282420
• 369611e: 8286677: [BACKOUT] (fc) Tune FileChannel.transferFrom()
• 4b8a66a: 8286424: GetVersionEx is deprecated
• 986d87d: 8274113: (fc) Tune FileChannel.transferFrom()
• ... and 34 more: https://git.openjdk.java.net/jdk/compare/89de756ffbefac452c7df559e2a4eb50bf71368b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 8daf08d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.