-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8286347: incorrect use of {@link}
#8584
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine in and of itself, but not sure how it will interact with the (presumed) integration of JEP 424: "Foreign Function & Memory API (Preview)" which will at least move the file, if not otherwise modify it.
I assume the changes are small and localized enough to not trigger any significant conflict. |
This is fixed in 8282191 (JEP 424), which is already integrated. |
Please review a small doc fix to update incorrect use of
{@link}
on arrays of primitive types.Progress
Issue
{@link}
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8584/head:pull/8584
$ git checkout pull/8584
Update a local copy of the PR:
$ git checkout pull/8584
$ git pull https://git.openjdk.java.net/jdk pull/8584/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8584
View PR using the GUI difftool:
$ git pr show -t 8584
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8584.diff