Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8286347: incorrect use of {@link} #8584

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented May 6, 2022

Please review a small doc fix to update incorrect use of {@link} on arrays of primitive types.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8584/head:pull/8584
$ git checkout pull/8584

Update a local copy of the PR:
$ git checkout pull/8584
$ git pull https://git.openjdk.java.net/jdk pull/8584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8584

View PR using the GUI difftool:
$ git pr show -t 8584

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8584.diff

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2022

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2022
@openjdk
Copy link

openjdk bot commented May 6, 2022

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 6, 2022
@mlbridge
Copy link

mlbridge bot commented May 6, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 6, 2022

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286347: incorrect use of `{@link}`

Reviewed-by: mchung, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2022
Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in and of itself, but not sure how it will interact with the (presumed) integration of JEP 424: "Foreign Function & Memory API (Preview)" which will at least move the file, if not otherwise modify it.

@jonathan-gibbons
Copy link
Contributor Author

Looks fine in and of itself, but not sure how it will interact with the (presumed) integration of JEP 424: "Foreign Function & Memory API (Preview)" which will at least move the file, if not otherwise modify it.

I assume the changes are small and localized enough to not trigger any significant conflict.

@liach
Copy link
Member

liach commented May 12, 2022

This is fixed in 8282191 (JEP 424), which is already integrated.

@jonathan-gibbons jonathan-gibbons deleted the 8286347.bad-link branch May 16, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants