-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286069: keytool prints out wrong key algorithm for -importpass command #8520
Conversation
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
.shouldHaveExitValue(0) | ||
.shouldContain("Generated PBE secret key"); | ||
|
||
// The aid of a protected entry (at 110c010c01010c0 inside p12) is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use "algorithm id" instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem.
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 075ce8a.
Your commit was automatically rebased without conflicts. |
Since
keytool -importpass
always usesKeyFactory.getInstance("PBE")
to generate the secret key, and "PBE" is an alias of "PBEwithMD5andDES" inside the SunJCE security provider, itsgetAlgorithm
is alwaysPBEwithMD5andDES
.This code change modifies it to "PBE".
Note that I haven't chosen the
-keyalg
option value here because it is actually the algorithm used to protect the PBE secret key entry. It's a cipher algorithm instead of a key algorithm.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8520/head:pull/8520
$ git checkout pull/8520
Update a local copy of the PR:
$ git checkout pull/8520
$ git pull https://git.openjdk.java.net/jdk pull/8520/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8520
View PR using the GUI difftool:
$ git pr show -t 8520
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8520.diff