Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec fields #8411

Closed
wants to merge 5 commits into from
+21 −13
Closed

8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec fields #8411

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f3981c
8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec f…
bradfordwetmore Apr 26, 2022
4e9e031
Addressed codereview comments on javadoc style.
bradfordwetmore Apr 27, 2022
e79b5d8
Minor IJ suggestion cleanup.
bradfordwetmore Apr 27, 2022
00edca0
Missed one minor codereview suggestion.
bradfordwetmore Apr 27, 2022
e733085
Use @ code tags instead of raw HTML
bradfordwetmore Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/java.base/share/classes/java/security/spec/MGF1ParameterSpec.java
View file
Original file line number Diff line number Diff line change
@@ -65,37 +65,37 @@
public class MGF1ParameterSpec implements AlgorithmParameterSpec {

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-1" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA-1" message digest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, use {@code} instead of <code/>. Otherwise, looks good.

*/
public static final MGF1ParameterSpec SHA1 =
new MGF1ParameterSpec("SHA-1");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-224" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA-224" message digest.
*/
public static final MGF1ParameterSpec SHA224 =
new MGF1ParameterSpec("SHA-224");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-256" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA-256" message digest.
*/
public static final MGF1ParameterSpec SHA256 =
new MGF1ParameterSpec("SHA-256");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-384" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA-384" message digest.
*/
public static final MGF1ParameterSpec SHA384 =
new MGF1ParameterSpec("SHA-384");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-512" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA-512" message digest.
*/
public static final MGF1ParameterSpec SHA512 =
new MGF1ParameterSpec("SHA-512");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-512/224"
* The <code>MGF1ParameterSpec</code> which uses a "SHA-512/224"
* message digest.
*
* @since 11
@@ -104,7 +104,7 @@ public class MGF1ParameterSpec implements AlgorithmParameterSpec {
new MGF1ParameterSpec("SHA-512/224");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA-512/256"
* The <code>MGF1ParameterSpec</code> which uses a "SHA-512/256"
* message digest.
*
* @since 11
@@ -113,31 +113,36 @@ public class MGF1ParameterSpec implements AlgorithmParameterSpec {
new MGF1ParameterSpec("SHA-512/256");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA3-224" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA3-224"
* message digest.
*
* @since 16
*/
public static final MGF1ParameterSpec SHA3_224 =
new MGF1ParameterSpec("SHA3-224");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA3-256" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA3-256"
* message digest.
*
* @since 16
*/
public static final MGF1ParameterSpec SHA3_256 =
new MGF1ParameterSpec("SHA3-256");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA3-384" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA3-384"
* message digest.
*
* @since 16
*/
public static final MGF1ParameterSpec SHA3_384 =
new MGF1ParameterSpec("SHA3-384");

/**
* The <code>MGF1ParameterSpec</code> which uses "SHA3-512" message digest.
* The <code>MGF1ParameterSpec</code> which uses a "SHA3-512"
* message digest.
*
* @since 16
*/
public static final MGF1ParameterSpec SHA3_512 =