-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8284890: Support for Do not fragment IP socket options #8245
Closed
+498
−3
Closed
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7cc694a
throwaway prototype
Michael-Mc-Mahon 542a403
linux support
Michael-Mc-Mahon cf28f8e
windows support
Michael-Mc-Mahon dd893d1
moved option to jdk.net
Michael-Mc-Mahon e4a797c
update
Michael-Mc-Mahon 002f676
updates
Michael-Mc-Mahon bab7b3f
building on all platforms
Michael-Mc-Mahon 026ef42
running on Macos
Michael-Mc-Mahon b59d7c1
running on Windows now
Michael-Mc-Mahon f8ed779
updates
Michael-Mc-Mahon 71004a6
fixed windows issue with getsockopt
Michael-Mc-Mahon 321f561
fixed test
Michael-Mc-Mahon 9a50c79
Merge branch 'master' into mtu
Michael-Mc-Mahon 3ebc1de
simplified test. Loosened spec
Michael-Mc-Mahon 47c3992
updates
Michael-Mc-Mahon 9b86592
test update
Michael-Mc-Mahon 6a39da9
windows update
Michael-Mc-Mahon 58db57e
windows issue
Michael-Mc-Mahon b26a29c
windows 2016 issue
Michael-Mc-Mahon a62ac1a
minor spec update
Michael-Mc-Mahon 446dd6c
fix whitespace errors
Michael-Mc-Mahon 14c776b
builds in github action now
Michael-Mc-Mahon a420ed0
Merge branch 'master' into mtu
Michael-Mc-Mahon 5458aae
test update
Michael-Mc-Mahon e90aa7c
windows update
Michael-Mc-Mahon 5f1d87e
updates
Michael-Mc-Mahon 509c3f8
fix whitespace
Michael-Mc-Mahon 1e08ee9
typo in windows native code
Michael-Mc-Mahon 428a980
test update
Michael-Mc-Mahon e6b12eb
test update
Michael-Mc-Mahon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a testcase for when DatagramChannel is opened using the no arg factory method
DatagramChannel.open()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there is value in testing all of these permutations. Distinguishing DatagramChannel and DatagramSocket probably made sense, but it's all the same implementation under the hood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DatagramChannel.open()
=> opens a dual socket unless-Djava.net.preferIPv4Stack=true
, in which case it should be equivalent toDatagramChannel.open(StandardProtocolFamily.INET)
DatagramChannel.open(StandardProtocolFamily.INET)
=> opens an IPv4 socketDatagramChannel.open(StandardProtocolFamily.INET6)
=> opens an IPv6 socketSo I believe it makes sense to test the no-arg constructor since that's the only way to open a dual socket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind adding it. Though, the no-arg constructor is the same as cases 2. or 3. depending on the value of the preferIPv4Stack property.