JDK-8274683 Code example provided by RandomGeneratorFactory does not compile

[JimLaskey]

A DESCRIPTION OF THE PROBLEM :
In https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGeneratorFactory.html the code provided as:
RandomGeneratorFactory best = RandomGeneratorFactory.all()
.sorted(Comparator.comparingInt(RandomGenerator::stateBits).reversed())
.findFirst()
.orElse(RandomGeneratorFactory.of("Random"));
does not compile.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Issues

• JDK-8274683: Code example provided by RandomGeneratorFactory does not compile
• JDK-8284013: Code example provided by RandomGeneratorFactory does not compile (CSR)

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8108/head:pull/8108
$ git checkout pull/8108

Update a local copy of the PR:
$ git checkout pull/8108
$ git pull https://git.openjdk.java.net/jdk pull/8108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8108

View PR using the GUI difftool:
$ git pr show -t 8108

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8108.diff

[JimLaskey]

/csr

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JimLaskey the issue for this pull request, JDK-8274683, already has an approved CSR request: JDK-8284013

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (367ca129)

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274683: Code example provided by RandomGeneratorFactory does not compile

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 526e734: 8282819: Deprecate Locale class constructors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JimLaskey]

/integrate

[openjdk]

Going to push as commit 4732b1d.
Since your change was applied there have been 202 commits pushed to the master branch:

• 42baaa3: 8023814: Test java/awt/im/memoryleak/InputContextMemoryLeakTest.java fails
• 9a905cc: 8285361: ClassCastExceptionForInvalidSurface.java has an incorrect copyright header
• 994a439: 8277816: Client tests fail on macos-Aarch64 host
• 9098343: 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill.MaskFill
• d6b5a63: 8284908: Refine diagnostic positions for DCErroneous
• fa04d1f: 8284949: riscv: Add Zero support for the 32-bit RISC-V architecture
• 994f2e9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
• 691c5da: 8285266: compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java fails after JDK-8284563
• 94afb36: 8285093: Introduce UTIL_ARG_WITH
• 8543aaa: 8283839: [JVMCI] add support for querying indy bootstrap method target and arguments
• ... and 192 more: https://git.openjdk.java.net/jdk/compare/648efd7abc93bf738723886ff941e3dd3aa622cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JimLaskey Pushed as commit 4732b1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.