Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282374: Java_sun_awt_X11_XlibWrapper_XSynchronize is wrong and unused #8016

Closed
wants to merge 1 commit into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Mar 29, 2022

This fix simply removes unused XSynchronize method.

Alternatively its return type may be changed to long, but I think less code is better.

Testing is green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282374: Java_sun_awt_X11_XlibWrapper_XSynchronize is wrong and unused

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8016/head:pull/8016
$ git checkout pull/8016

Update a local copy of the PR:
$ git checkout pull/8016
$ git pull https://git.openjdk.java.net/jdk pull/8016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8016

View PR using the GUI difftool:
$ git pr show -t 8016

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8016.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282374: Java_sun_awt_X11_XlibWrapper_XSynchronize is wrong and unused

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 272d653: 8283889: Fix Typo in open/src/java.sql/share/classes/java/sql/package-info.java
  • a9a9b90: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows
  • 489b27d: 8282776: Bad NullPointerException message when invoking an interface MethodHandle on a null receiver
  • 072f2c4: 8283782: Redundant verification of year in LocalDate::ofEpochDay
  • 2fef5d4: 8281853: serviceability/sa/ClhsdbThreadContext.java failed with NullPointerException: Cannot invoke "sun.jvm.hotspot.gc.shared.GenCollectedHeap.getGen(int)" because "this.heap" is null
  • f9f439a: 8283717: vmTestbase/nsk/jdi/ThreadStartEvent/thread/thread001 failed due to SocketTimeoutException
  • 9591306: 8283772: Make sun.net.dns.ResolverConfiguration sealed
  • 5359387: 8024624: [TEST_BUG] [macosx] CTRL+RIGHT(LEFT) doesn't move selection on next cell in JTable on Aqua L&F
  • f074775: 8281284: Write JSlider accessibility test
  • fe670ff: 8283692: Add PrintIdealPhase that includes block scheduling
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/c3d903a55a9f606db8604d5a8c091b0fc3c6a988...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2022
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

Going to push as commit ec9ab55.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@azvegint Pushed as commit ec9ab55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants