Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283558: Parallel: Pass PSIsAliveClosure to ReferenceProcessor constructor #7918

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 23, 2022

Simple change around non-strong ref discovery in young-gc ref-processing.

Test: tier1-6


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283558: Parallel: Pass PSIsAliveClosure to ReferenceProcessor constructor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7918/head:pull/7918
$ git checkout pull/7918

Update a local copy of the PR:
$ git checkout pull/7918
$ git pull https://git.openjdk.java.net/jdk pull/7918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7918

View PR using the GUI difftool:
$ git pr show -t 7918

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7918.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 23, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283558: Parallel: Pass PSIsAliveClosure to ReferenceProcessor constructor

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2022
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

Going to push as commit 7f12537.
Since your change was applied there have been 70 commits pushed to the master branch:

  • 66f1da1: 8281222: ciTypeFlow::profiled_count fails "assert(0 <= i && i < _len) failed: illegal index"
  • c2c0cb2: 8282668: HotSpot Style Guide should permit unrestricted unions
  • b0daf70: 8263134: HotSpot Style Guide should disallow inheriting constructors
  • c587b29: 8283720: ProblemList java/time/test/java/time/TestZoneOffset.java
  • d5f9059: 8283695: [AIX] Build failure due to name conflict in test_arguments.cpp
  • f520b4f: 8283668: Update IllegalFormatException to use sealed classes
  • 5ca8b91: 8283713: [BACKOUT] Unexpected TypeElement in ANALYZE TaskEvent
  • 7bac0a8: 8283681: Improve ZonedDateTime offset handling
  • 2600f99: 8282685: fileToEncodedURL_[name|signature] symbols are unused
  • e97cf15: 8283691: Classes in java.security still reference deprecated classes in spec
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/85628a871df3fdeec1b422d1c01c222abe45d0a8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2022
@openjdk openjdk bot closed this Mar 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@albertnetymk Pushed as commit 7f12537.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the ps-is-alive-closure branch March 28, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants