Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283049: Fix non-singleton LoggerFinder error message: s/on/one #7780

Closed

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Mar 10, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283049: Fix non-singleton LoggerFinder error message: s/on/one

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7780/head:pull/7780
$ git checkout pull/7780

Update a local copy of the PR:
$ git checkout pull/7780
$ git pull https://git.openjdk.java.net/jdk pull/7780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7780

View PR using the GUI difftool:
$ git pr show -t 7780

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7780.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2022

👋 Welcome back carterkozak! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@carterkozak The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 10, 2022
@carterkozak carterkozak force-pushed the ckozak/multiple_loggerfinders branch 2 times, most recently from b05f717 to 654aea9 Compare March 10, 2022 22:34
@carterkozak
Copy link
Contributor Author

Unfortunately I lack the permissions to create an issue for this. @dfuch is there any chance you could help me create the issue?

Verified

This commit was signed with the committer’s verified signature.
carterkozak Carter Kozak
@carterkozak carterkozak force-pushed the ckozak/multiple_loggerfinders branch from 654aea9 to a78180d Compare March 11, 2022 18:38
@carterkozak carterkozak changed the title Fix non-singleton LoggerFinder error message: s/on/one 8283049: Fix non-singleton LoggerFinder error message: s/on/one Mar 11, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@dfuch
Copy link
Member

dfuch commented Mar 11, 2022

I changed the bug title to match the PR title.

@@ -230,7 +230,7 @@ static LoggerFinder getLoggerFinder(Class<?> expectedClass,
throw new RuntimeException("Expected message not found. Error stream contained: " + warning);
}
} else if (singleton) {
if (!warning.contains("java.util.ServiceConfigurationError: More than on LoggerFinder implementation")) {
if (!warning.contains("java.util.ServiceConfigurationError: More than one LoggerFinder implementation")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add 8283049 to the @bug list above since the test actually verifies the fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

Verified

This commit was signed with the committer’s verified signature.
carterkozak Carter Kozak
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@carterkozak This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283049: Fix non-singleton LoggerFinder error message: s/on/one

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 7833667: 8282881: Print exception message in VM crash with -XX:AbortVMOnException
  • c96085e: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • 13cebff: 8058924: FileReader(String) documentation is insufficient
  • 08573cc: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
  • ea9eeea: 8281322: C2: always construct strip mined loop initially (even if strip mining is disabled)
  • 5f3d403: 8272735: Add missing SubL node transformations
  • 01570ca: 8283017: GHA: Workflows break with update release versions
  • c0e3d10: 8283008: KRegister documentation out of date
  • fde3149: 8281375: Accelerate bitCount operation for AVX2 and AVX512 target.
  • 3cf83a6: 8282572: EnumSet should be a sealed class
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/bb7ee5a04ae21a9f9dc6c59a990f7e571e832f0d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2022
@carterkozak
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@carterkozak
Your change (at version 8406b3e) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented Mar 14, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

Going to push as commit 70bd57e.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 7833667: 8282881: Print exception message in VM crash with -XX:AbortVMOnException
  • c96085e: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • 13cebff: 8058924: FileReader(String) documentation is insufficient
  • 08573cc: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket
  • ea9eeea: 8281322: C2: always construct strip mined loop initially (even if strip mining is disabled)
  • 5f3d403: 8272735: Add missing SubL node transformations
  • 01570ca: 8283017: GHA: Workflows break with update release versions
  • c0e3d10: 8283008: KRegister documentation out of date
  • fde3149: 8281375: Accelerate bitCount operation for AVX2 and AVX512 target.
  • 3cf83a6: 8282572: EnumSet should be a sealed class
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/bb7ee5a04ae21a9f9dc6c59a990f7e571e832f0d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@dfuch @carterkozak Pushed as commit 70bd57e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants