-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283049: Fix non-singleton LoggerFinder error message: s/on/one #7780
8283049: Fix non-singleton LoggerFinder error message: s/on/one #7780
Conversation
👋 Welcome back carterkozak! A progress list of the required criteria for merging this PR into |
@carterkozak The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
b05f717
to
654aea9
Compare
Unfortunately I lack the permissions to create an issue for this. @dfuch is there any chance you could help me create the issue? |
654aea9
to
a78180d
Compare
Webrevs
|
I changed the bug title to match the PR title. |
@@ -230,7 +230,7 @@ static LoggerFinder getLoggerFinder(Class<?> expectedClass, | |||
throw new RuntimeException("Expected message not found. Error stream contained: " + warning); | |||
} | |||
} else if (singleton) { | |||
if (!warning.contains("java.util.ServiceConfigurationError: More than on LoggerFinder implementation")) { | |||
if (!warning.contains("java.util.ServiceConfigurationError: More than one LoggerFinder implementation")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add 8283049 to the @bug
list above since the test actually verifies the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks!
@carterkozak This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@carterkozak |
/sponsor |
Going to push as commit 70bd57e.
Your commit was automatically rebased without conflicts. |
@dfuch @carterkozak Pushed as commit 70bd57e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7780/head:pull/7780
$ git checkout pull/7780
Update a local copy of the PR:
$ git checkout pull/7780
$ git pull https://git.openjdk.java.net/jdk pull/7780/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7780
View PR using the GUI difftool:
$ git pr show -t 7780
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7780.diff