Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282467: add extra diagnostics for JDK-8268184 #7642

Closed
wants to merge 1 commit into from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Mar 1, 2022

Add more info to the assert to help diagnose what went wrong the next time it fails.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7642/head:pull/7642
$ git checkout pull/7642

Update a local copy of the PR:
$ git checkout pull/7642
$ git pull https://git.openjdk.java.net/jdk pull/7642/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7642

View PR using the GUI difftool:
$ git pr show -t 7642

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7642.diff

Sorry, something went wrong.

@dean-long dean-long marked this pull request as ready for review March 1, 2022 03:48
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2022

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8282467: add extra diagnostics for JDK-8268184 8282467: add extra diagnostics for JDK-8268184 Mar 1, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@dean-long The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 1, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and trivial).

Cheers, Thomas

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282467: add extra diagnostics for JDK-8268184

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e4d9fc8: 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale
  • c1a28aa: 8282392: [zero] Build broken on AArch64
  • 7743266: 8281210: Add manpage changes for PAC-RET protection on Linux/AArch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2022
@dean-long
Copy link
Member Author

Thanks Thomas!

@dean-long
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

Going to push as commit d3022f8.
Since your change was applied there have been 3 commits pushed to the master branch:

  • e4d9fc8: 8282023: PropertiesStoreTest and StoreReproducibilityTest jtreg failures due to en_CA locale
  • c1a28aa: 8282392: [zero] Build broken on AArch64
  • 7743266: 8281210: Add manpage changes for PAC-RET protection on Linux/AArch64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@dean-long Pushed as commit d3022f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants