Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266670: Better modeling of access flags in core reflection #7445

Closed
wants to merge 53 commits into from
Closed
Changes from 2 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
6a6b958
JDK-8266670: Better modeling of modifiers in core reflection
jddarcy Feb 11, 2022
21cd92f
Merge branch 'master' into JDK-8266670
jddarcy Feb 14, 2022
74ec715
Fix typo from review feedback.
jddarcy Feb 14, 2022
88be1e3
Respond to review feedback explicitly stating returned sets are immut…
jddarcy Feb 14, 2022
ab623f8
Respond to more review feedback.
jddarcy Feb 14, 2022
998af61
Merge branch 'master' into JDK-8266670
jddarcy Feb 15, 2022
2f9b168
Reorder constants by mask value per review feedback.
jddarcy Feb 15, 2022
695761e
Merge branch 'master' into JDK-8266670
jddarcy Feb 16, 2022
0222810
Update JVMS references.
jddarcy Feb 17, 2022
c33a8cc
Merge branch 'master' into JDK-8266670
jddarcy Feb 17, 2022
5cc6ba5
Add support for module flags; fix typo.
jddarcy Feb 17, 2022
131010f
Respond to review feedback.
jddarcy Feb 17, 2022
c3f6b0a
Switch to location enum.
jddarcy Feb 18, 2022
3bb337b
Merge branch 'master' into JDK-8266670
jddarcy Feb 22, 2022
8d31115
Minor cleanup.
jddarcy Feb 22, 2022
46d4d7e
Add test for location disjointness
jddarcy Feb 22, 2022
bb4a301
Add mask to access flag functionality.
jddarcy Feb 23, 2022
e8f5b7d
Initial support for accessFlags methods
jddarcy Feb 23, 2022
9ddef05
Merge branch 'master' into JDK-8266670
jddarcy Feb 23, 2022
a43f733
Fix some bugs found by inspection, docs cleanup.
jddarcy Feb 23, 2022
8872875
Appease jcheck.
jddarcy Feb 24, 2022
aa2b5ee
Typo fix; add implSpec to Executable.
jddarcy Feb 24, 2022
fb13e79
Merge branch 'master' into JDK-8266670
jddarcy Mar 1, 2022
e63fb13
Make workding changes suggested in review feedback.
jddarcy Mar 1, 2022
5a9dfca
Merge branch 'master' into JDK-8266670
jddarcy Mar 5, 2022
1498060
Respond to review feedback.
jddarcy Mar 5, 2022
7f3a9fb
Merge branch 'master' into JDK-8266670
jddarcy May 3, 2022
01c6c98
Fix type in @throws tag.
jddarcy May 3, 2022
8a3a3cd
Implement review feedback from mlchung.
jddarcy May 3, 2022
ead5911
Add mask values to constants' javadoc.
jddarcy May 3, 2022
8eb6a5e
Merge branch 'master' into JDK-8266670
jddarcy May 25, 2022
05cf2d8
Target JDK 20 rather than 19.
jddarcy May 25, 2022
c2c716e
Merge branch 'master' into JDK-8266670
jddarcy Jun 13, 2022
111c601
Update to use @value tag.
jddarcy Jun 13, 2022
840edf2
From review feedback, use package-private contstants in Modifier.
jddarcy Jun 13, 2022
fd682ac
Correct STATIC vs STATIC_PHASE issue found in code review.
jddarcy Jun 13, 2022
75ac9c1
Make mask fields final in ModuleDescriptor.
jddarcy Jun 14, 2022
adcbcb7
Respond to review feedback.
jddarcy Jun 14, 2022
3e4a1ed
Respond to review feedback from Roger Riggs.
jddarcy Jun 14, 2022
2778932
Merge branch 'master' into JDK-8266670
jddarcy Jun 16, 2022
9395cfd
Expand regression tests.
jddarcy Jun 16, 2022
ebb01e1
Appease jcheck.
jddarcy Jun 16, 2022
bfbb033
Merge branch 'master' into JDK-8266670
jddarcy Jun 16, 2022
81e6ef0
Fix typo Exe-Boss spotted in review feedback.
jddarcy Jun 16, 2022
81bfc6d
Add module-related tests.
jddarcy Jun 17, 2022
3a67d9b
Merge branch 'master' into JDK-8266670
jddarcy Jun 17, 2022
98f12bb
Expand scope of tests.
jddarcy Jun 21, 2022
9d72436
Improve support and tests for Class objects representing arrays and p…
jddarcy Jun 21, 2022
617c9aa
Remove implSpec tag from Executable.accessFlags since the class is se…
jddarcy Jun 21, 2022
63c4828
Respond to review feedback from Mandy and Roger.
jddarcy Jun 23, 2022
91605a8
Merge branch 'master' into JDK-8266670
jddarcy Jun 23, 2022
f807bda
Merge branch 'master' into JDK-8266670
jddarcy Jun 24, 2022
e2cccc1
Expand testing of Class access flags.
jddarcy Jun 25, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@
* public}. In other cases, some language-level modifiers do
* <em>not</em> have an access flag, such as {@code sealed} (JVMS
* {@jvms 4.7.31}) and some access flags have no corresponding
* modifier, such as {@linkplain SYNTHETIC synthetic}.
* modifier, such as {@linkplain SYNTHETIC synthetic}.
*
* <p>The values for the constants representing the access and module
* flags are taken from sections of <cite>The Java Virtual Machine