Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280903: javadoc build fails after JDK-4774868 #7277

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Jan 28, 2022

Prefix java.io to FOS and RAF links.
(Redo of 7273 whose branch was deleted before integrating).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7277/head:pull/7277
$ git checkout pull/7277

Update a local copy of the PR:
$ git checkout pull/7277
$ git pull https://git.openjdk.java.net/jdk pull/7277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7277

View PR using the GUI difftool:
$ git pr show -t 7277

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7277.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jan 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280903: javadoc build fails after JDK-4774868

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9139159: 8280843: macos-Aarch64 SEGV in frame::sender_for_compiled_frame after JDK-8277948
  • 0740ac4: 8280555: serviceability/sa/TestObjectMonitorIterate.java is failing due to ObjectMonitor referencing a null Object
  • ff34d62: 8280898: ProblemList compiler/regalloc/TestC2IntPressure.java on macosx-aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 28, 2022
@bplb
Copy link
Member Author

bplb commented Jan 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

Going to push as commit d366d15.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 9139159: 8280843: macos-Aarch64 SEGV in frame::sender_for_compiled_frame after JDK-8277948
  • 0740ac4: 8280555: serviceability/sa/TestObjectMonitorIterate.java is failing due to ObjectMonitor referencing a null Object
  • ff34d62: 8280898: ProblemList compiler/regalloc/TestC2IntPressure.java on macosx-aarch64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 28, 2022
@openjdk openjdk bot closed this Jan 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@bplb Pushed as commit d366d15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the FileChannel-force-8280903 branch March 14, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

2 participants