Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11 #7060

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 13, 2022

Test is timing out on slower windows11 CI system. Increased the timeout and also adjusted autodelay time to more consistent time with other headful tests which makes test pass in windows11.
Test job link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7060/head:pull/7060
$ git checkout pull/7060

Update a local copy of the PR:
$ git checkout pull/7060
$ git pull https://git.openjdk.java.net/jdk pull/7060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7060

View PR using the GUI difftool:
$ git pr show -t 7060

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7060.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2022
@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 15, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11

Reviewed-by: serb, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 145 new commits pushed to the master branch:

  • b0496b0: 8279970: two AppCDS tests fail after JDK-8261455
  • 4eb4f94: 8279956: Useless method Scheduling::ComputeLocalLatenciesForward()
  • 4f4da3b: 8275318: loaded_classes_do may see ArrayKlass before InstanceKlass is loaded
  • 3a421e4: 8280122: SupportedGroupsExtension should output "named groups" rather than "versions"
  • 1a20628: 8248404: AArch64: Remove uses of long and unsigned long
  • 46fd683: 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10
  • e314a4c: 8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes
  • bdfa15d: 8250801: Add clhsdb "threadcontext" command
  • fd9fb9a: 8279194: Add Annotated Memory Viewer feature to SA's HSDB
  • 848b16a: 8272746: ZipFile can't open big file (NegativeArraySizeException)
  • ... and 135 more: https://git.openjdk.java.net/jdk/compare/62d03c283667c4122130ec9bbeec623e6a2840e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 15, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

Going to push as commit c4a624d.
Since your change was applied there have been 201 commits pushed to the master branch:

  • 4616c13: Merge
  • 03680be: 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl
  • be0538d: 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling
  • f5de6fa: 8272058: 25 Null pointer dereference defect groups in 4 files
  • 28e02fa: 8280234: AArch64 "core" variant does not build after JDK-8270947
  • f37bfea: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 69cfa9c: 8273383: vmTestbase/vm/gc/containers/Combination05/TestDescription.java crashes verifying length of DCQS
  • af6c9ab: 8279654: jdk/incubator/vector/Vector256ConversionTests.java crashes randomly with SVE
  • 6d3fd86: 8278417: Closed test fails after JDK-8276108 on aarch64
  • 82d6afe: 8274096: Improve decoding of image files
  • ... and 191 more: https://git.openjdk.java.net/jdk/compare/62d03c283667c4122130ec9bbeec623e6a2840e5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2022
@openjdk openjdk bot closed this Jan 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@prsadhuk Pushed as commit c4a624d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8279894 branch January 20, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants