Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276141: XPathFactory set/getProperty method #6215

Closed
wants to merge 11 commits into from
+255 −11
Closed

8276141: XPathFactory set/getProperty method #6215

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b0b9ae2
8276141: XPathFactory set/getProperty method
JoeWang-Java Nov 2, 2021
569c6cd
Add default impl; Add tests.
JoeWang-Java Nov 3, 2021
52323c7
drop: in the XPath API
JoeWang-Java Nov 5, 2021
d294d98
Exception: changed from XPathFactoryConfigurationException to Illegal…
JoeWang-Java Nov 5, 2021
fae6a9e
Exception: changed from XPathFactoryConfigurationException to Illegal…
JoeWang-Java Nov 5, 2021
f85700e
Removing IAE from the method signature; Update impl and test.
JoeWang-Java Nov 5, 2021
901ebc0
javadoc clarification for setFeature and setProperty
JoeWang-Java Nov 9, 2021
56ede26
Update as commented
JoeWang-Java Nov 9, 2021
e1157ea
adjust wording
JoeWang-Java Nov 10, 2021
3f1ca15
update as commented
JoeWang-Java Nov 18, 2021
c791758
Add a statement to clarify the space of the properties
JoeWang-Java Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java
View file
Original file line number Diff line number Diff line change
@@ -275,8 +275,9 @@ public static XPathFactory newInstance(String uri, String factoryClassName, Clas
public abstract boolean isObjectModelSupported(String objectModel);

/**
* <p>Set a feature for this {@code XPathFactory} and
* <code>XPath</code>s created by this factory.</p>
* Sets a feature for this {@code XPathFactory}. A feature set on the
* factory is effective to the {@code XPath} object created thereafter, but
* not ones that may have been created beforehand.
*
* <p>
* Feature names are fully qualified {@link java.net.URI}s.
@@ -371,8 +372,9 @@ public abstract boolean getFeature(String name)
public abstract XPath newXPath();

/**
* Sets a property for this {@code XPathFactory} and {@code XPath}
* created by this factory.
* Sets a property for this {@code XPathFactory}. A property set on the
* factory is effective to the {@code XPath} object created thereafter, but
* not ones that may have been created beforehand.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be clear to say something like "The property has no impact on XPath object that are already created".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alan. Updated accordingly.

*
* @implSpec
* The default implementation throws