Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275821: Optimize random number generators developed in JDK-8248862 using Math.unsignedMultiplyHigh() #6206

Closed
wants to merge 8 commits into from
+75 −31
Closed

8275821: Optimize random number generators developed in JDK-8248862 using Math.unsignedMultiplyHigh() #6206

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3103ffc
8275821: Optimize random number generators developed in JDK-8248862 u…
vamsi-parasa Nov 2, 2021
c6ec648
Update Math.java
vamsi-parasa Nov 2, 2021
49146d2
micro benchmarks to test the performance
vamsi-parasa Nov 5, 2021
e46c2d9
Fix year in copyright
vamsi-parasa Nov 5, 2021
8bde473
fix trailing whitespace
vamsi-parasa Nov 5, 2021
78a4514
add seeds for the random generators to eliminate run-to-run variance
vamsi-parasa Dec 2, 2021
e9c7147
Update the JMH micro to take RNG parameters for elegant implementation
vamsi-parasa Dec 3, 2021
cf68fe0
minor changes to the benchmark
vamsi-parasa Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/micro/org/openjdk/bench/java/util/RandomGeneratorNext.java
View file
Original file line number Diff line number Diff line change
@@ -29,9 +29,7 @@
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Param;

import java.util.random.RandomGenerator;
import java.util.random.RandomGeneratorFactory;
import java.util.concurrent.TimeUnit;
@@ -44,12 +42,12 @@
@State(Scope.Thread)
public class RandomGeneratorNext {

public RandomGenerator randomGenerator;
RandomGenerator randomGenerator;

@Param({"L128X128MixRandom", "L128X256MixRandom", "L128X1024MixRandom"})
String randomGeneratorName;

public static long[] buffer;
long[] buffer;

@Param("1024")
int size;
@@ -66,9 +64,9 @@ public long testNextLong() {
}

@Benchmark
@Fork(1)
public void testFillBufferWithNextLong() {
public long[] testFillBufferWithNextLong() {
for (int i = 0; i < size; i++) buffer[i] = randomGenerator.nextLong();
return buffer;
}

}