Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276266: Clean up incorrect client-libs ProblemList.txt entries #6203

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Nov 2, 2021

We have a few stale entries in the Problem list.
We need to remap some tests to still open bugs
7100044 -> 6849371
8203047 -> 8072110
8233703 -> 8238436
8273618 -> 8273617

We need to remove these FIXED bugs
java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java 7185258 macosx-all

java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java 8000171 windows-all
(actually closed as a dup of 8196100 which is fixed)

And this RESOLVED / not reproducible.
java/awt/SplashScreen/MultiResolutionSplash/MultiResolutionSplashTest.java 8061235 macosx-all

I've verified that the removed ones do pass in the CI test system so we should be OK unless they are very intermittent or environment specific


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8276266: Clean up incorrect client-libs ProblemList.txt entries

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6203/head:pull/6203
$ git checkout pull/6203

Update a local copy of the PR:
$ git checkout pull/6203
$ git pull https://git.openjdk.java.net/jdk pull/6203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6203

View PR using the GUI difftool:
$ git pr show -t 6203

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6203.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prrace
Copy link
Contributor Author

prrace commented Nov 2, 2021

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@prrace
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 2, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Nov 2, 2021

I am not sure why the macOS-specific JDK-8203047 was closed as a duplicate of x11 specific JDK-8072110?
The HandleExceptionOnEDT from the JDK-8203047 is not even mentioned in the JDK-8072110.

@prrace
Copy link
Contributor Author

prrace commented Nov 2, 2021

I am not sure why the macOS-specific JDK-8203047 was closed as a duplicate of x11 specific JDK-8072110?
The HandleExceptionOnEDT from the JDK-8203047 is not even mentioned in the JDK-8072110.

I don't know. This was done by @prsadhuk - Prasanta can you explain that ?

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2021

@prrace This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Dec 22, 2021

Any updates on that @prrace @prsadhuk?

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2022

@prrace This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

@prrace This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Feb 17, 2022
@prrace
Copy link
Contributor Author

prrace commented Apr 27, 2022

/open

@prrace
Copy link
Contributor Author

prrace commented Apr 27, 2022

@prsadhuk - still looking for a response from you.

@openjdk openjdk bot reopened this Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@prrace This pull request is now open

@prsadhuk
Copy link
Contributor

I am not sure why the macOS-specific JDK-8203047 was closed as a duplicate of x11 specific JDK-8072110?
The HandleExceptionOnEDT from the JDK-8203047 is not even mentioned in the JDK-8072110.

I don't know. This was done by @prsadhuk - Prasanta can you explain that ?

I am not sure on this now...Seems like it might have been a mistake seeing it now..probably I was trying to close as dup with some other JBS but inadvertently mentioned the wrong one..

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 23, 2022

@prrace this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout pl_cleanup
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed rfr Pull request is ready for review labels May 23, 2022
@prrace prrace closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch
Development

Successfully merging this pull request may close these issues.

None yet

4 participants