-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276266: Clean up incorrect client-libs ProblemList.txt entries #6203
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label client |
@prrace |
Webrevs
|
I am not sure why the macOS-specific JDK-8203047 was closed as a duplicate of x11 specific JDK-8072110? |
I don't know. This was done by @prsadhuk - Prasanta can you explain that ? |
@prrace This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@prrace This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@prrace This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@prsadhuk - still looking for a response from you. |
@prrace This pull request is now open |
I am not sure on this now...Seems like it might have been a mistake seeing it now..probably I was trying to close as dup with some other JBS but inadvertently mentioned the wrong one.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@prrace this pull request can not be integrated into git checkout pl_cleanup
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
We have a few stale entries in the Problem list.
We need to remap some tests to still open bugs
7100044 -> 6849371
8203047 -> 8072110
8233703 -> 8238436
8273618 -> 8273617
We need to remove these FIXED bugs
java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java 7185258 macosx-all
java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java 8000171 windows-all
(actually closed as a dup of 8196100 which is fixed)
And this RESOLVED / not reproducible.
java/awt/SplashScreen/MultiResolutionSplash/MultiResolutionSplashTest.java 8061235 macosx-all
I've verified that the removed ones do pass in the CI test system so we should be OK unless they are very intermittent or environment specific
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6203/head:pull/6203
$ git checkout pull/6203
Update a local copy of the PR:
$ git checkout pull/6203
$ git pull https://git.openjdk.java.net/jdk pull/6203/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6203
View PR using the GUI difftool:
$ git pr show -t 6203
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6203.diff