Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276220: Reduce excessive allocations in DateTimeFormatter #6188

Closed
wants to merge 10 commits into from
+552 −31
Closed

8276220: Reduce excessive allocations in DateTimeFormatter #6188

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e97b4d
8276220: Reduce excessive allocations in DateTimeFormatter
cl4es Nov 1, 2021
ee13139
Remove stray method
cl4es Nov 1, 2021
2109232
Add fallback for values outside the allowable range
cl4es Nov 2, 2021
579b2c0
Single-check idiom
cl4es Nov 3, 2021
f887c0d
FractionPrinterParser checks values to be in range; NanosPrinterParse…
cl4es Nov 3, 2021
1d21a1a
Add test verifying OOB values throw exception
cl4es Nov 3, 2021
3ce6d97
Minor cleanup
cl4es Nov 3, 2021
01fce43
Add MICRO_OF_SECOND tests to retain proper coverage of FractionPrinte…
cl4es Nov 3, 2021
f6adb5b
Copyrights
cl4es Nov 3, 2021
b663fe6
Remove accidentally committed experimental @Stable (no effect on micros)
cl4es Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
View file
Original file line number Diff line number Diff line change
@@ -3262,10 +3262,12 @@ public boolean format(DateTimePrintContext context, StringBuilder buf) {
// While values of ChronoField.NANO_OF_SECOND should be in the range
// [0-999999999], we can't assume that holds for any custom Temporal
if (!field.range().isValidIntValue(value)) {
if (fallback == null) {
fallback = new FractionPrinterParser(field, minWidth, maxWidth, decimalPoint, subsequentWidth);
var fallbackFormatter = fallback;
if (fallbackFormatter == null) {
fallbackFormatter = new FractionPrinterParser(field, minWidth, maxWidth, decimalPoint, subsequentWidth);
fallback = fallbackFormatter;
}
return fallback.format(context, buf);
return fallbackFormatter.format(context, buf);
}
int val = value.intValue();
DecimalStyle decimalStyle = context.getDecimalStyle();