8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter

[turbanoff]

This calls are redundant, because order of p0 and p1 is checked in method pre-conditions.
Checks were added under JDK-6771184 - 79ed0e75ceeb

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter

Reviewers

• Pankaj Bansal (@pankaj-bansal - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5542/head:pull/5542
$ git checkout pull/5542

Update a local copy of the PR:
$ git checkout pull/5542
$ git pull https://git.openjdk.java.net/jdk pull/5542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5542

View PR using the GUI difftool:
$ git pr show -t 5542

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5542.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shipilev]

@turbanoff, you are already recorded as Author, which means you have the access to JIRA? Could you please submit the bug yourself and change the title of this PR accordingly?

[mlbridge]

Webrevs

• 00: Full (9cef9c65)

[pankaj-bansal]

Looks fine to me. Please wait for a second review before committing.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273907: Cleanup redundant Math.max/min calls in DefaultHighlighter

Reviewed-by: pbansal, aivanov, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
• 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
• 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
• dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
• 48aff23: 8272515: JFR: Names should only be valid Java identifiers
• 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
• 9aa12da: 8273934: Remove unused perfcounters
• 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
• 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
• 1f8af52: 8273314: Add tier4 test groups
• ... and 32 more: https://git.openjdk.java.net/jdk/compare/46af82e5b0d176e340f46125f8a3bb17e56bd7b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pankaj-bansal, @aivanov-jdk, @azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version 9cef9c6) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit b3b4b1c.
Since your change was applied there have been 42 commits pushed to the master branch:

• a67f0f9: 8273505: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#default-cl crashed with SIGSEGV in MetaspaceShared::link_shared_classes
• 26e5e9a: 8273654: JFR: Remove unused SecuritySupport.setAccessible(Field)
• 4b3a4ff: 8273940: vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java crashes in full gc during VM exit
• dad5d27: 8272867: JFR: ManagementSupport.removeBefore() lost coverage
• 48aff23: 8272515: JFR: Names should only be valid Java identifiers
• 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
• 9aa12da: 8273934: Remove unused perfcounters
• 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
• 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
• 1f8af52: 8273314: Add tier4 test groups
• ... and 32 more: https://git.openjdk.java.net/jdk/compare/46af82e5b0d176e340f46125f8a3bb17e56bd7b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @turbanoff Pushed as commit b3b4b1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.