-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272867: JFR: ManagementSupport.removeBefore() lost coverage #5453
Conversation
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@egahlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 141 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit dad5d27.
Your commit was automatically rebased without conflicts. |
Hi,
Could I have a review of a fix that removes an unused method
Testing: jdk/jdk/jfr
Thanks
Erik
Progress
Issue
8272867
.Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5453/head:pull/5453
$ git checkout pull/5453
Update a local copy of the PR:
$ git checkout pull/5453
$ git pull https://git.openjdk.java.net/jdk pull/5453/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5453
View PR using the GUI difftool:
$ git pr show -t 5453
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5453.diff