8272867: JFR: ManagementSupport.removeBefore() lost coverage

[egahlin]

Hi,

Could I have a review of a fix that removes an unused method

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• ⚠️ Failed to retrieve information on issue 8272867.

Reviewers

• Mikhailo Seledtsov (@mseledts - Committer)
• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5453/head:pull/5453
$ git checkout pull/5453

Update a local copy of the PR:
$ git checkout pull/5453
$ git pull https://git.openjdk.java.net/jdk pull/5453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5453

View PR using the GUI difftool:
$ git pr show -t 5453

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5453.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (35c7fa2a)

[mseledts]

Looks good to me.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272867: JFR: ManagementSupport.removeBefore() lost coverage

Reviewed-by: mseledtsov, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

• 48aff23: 8272515: JFR: Names should only be valid Java identifiers
• 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
• 9aa12da: 8273934: Remove unused perfcounters
• 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
• 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
• 1f8af52: 8273314: Add tier4 test groups
• 699865f: 8259039: Passing different version to --release flag than javac version output warning
• f71df14: 8273187: jtools tests fail with missing markerName check
• 6f3e40c: 8273825: TestIRMatching.java fails after JDK-8266550
• a561eac: 8273895: compiler/ciReplay/TestVMNoCompLevel.java fails due to wrong data size with TieredStopAtLevel=2,3
• ... and 131 more: https://git.openjdk.java.net/jdk/compare/cb112affd6061e8ace6dad4e92c7b394a413e37f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit dad5d27.
Since your change was applied there have been 141 commits pushed to the master branch:

• 48aff23: 8272515: JFR: Names should only be valid Java identifiers
• 4d95a5d: 8273933: [TESTBUG] Test must run without preallocated exceptions
• 9aa12da: 8273934: Remove unused perfcounters
• 4da45c4: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction
• 544193a: 8247980: Exclusive execution of java/util/stream tests slows down tier1
• 1f8af52: 8273314: Add tier4 test groups
• 699865f: 8259039: Passing different version to --release flag than javac version output warning
• f71df14: 8273187: jtools tests fail with missing markerName check
• 6f3e40c: 8273825: TestIRMatching.java fails after JDK-8266550
• a561eac: 8273895: compiler/ciReplay/TestVMNoCompLevel.java fails due to wrong data size with TieredStopAtLevel=2,3
• ... and 131 more: https://git.openjdk.java.net/jdk/compare/cb112affd6061e8ace6dad4e92c7b394a413e37f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit dad5d27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.