8271569: Clean up the use of CDS constants and field offsets

[yminqi]

Changed cdsOffsets.cpp to cdsConstants.cpp, now the offsets and constants are initialized static and searched separately.
The offsets array could not use 'constexpr' since g++ on MacOs and VSC++ on Windows complained reinterpret_cast in 'offset_of' should not be used in constexpr initialization. Changed some field access for forming global list first.

Tests: ter1-4

Thanks
Yumin

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271569: Change cdsoffsets.cpp to cdsConstants.cpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5423/head:pull/5423
$ git checkout pull/5423

Update a local copy of the PR:
$ git checkout pull/5423
$ git pull https://git.openjdk.java.net/jdk pull/5423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5423

View PR using the GUI difftool:
$ git pr show -t 5423

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5423.diff

[bridgekeeper]

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yminqi The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d394c59c)

[yminqi]

/label add hotspot-runtime

[openjdk]

@yminqi
The hotspot-runtime label was successfully added.

[dholmes-ora]

Hi Yumin,

Changed cdsOffsets.cpp to cdsConstants.cpp

This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.

David

[yminqi]

Hi Yumin,

Changed cdsOffsets.cpp to cdsConstants.cpp

This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.

David

Hi, David
git did not rename the 'old' to 'new' so the patch showed cdsConstants.cpp as a 'new' file. So I will change description as you indicated. Thanks

Yumin

[mlbridge]

Mailing list message from David Holmes on hotspot-dev:

On 9/09/2021 1:16 pm, Yumin Qi wrote:

On Wed, 8 Sep 2021 22:44:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

Hi Yumin,

Changed cdsOffsets.cpp to cdsConstants.cpp

This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.

David

Hi, David
git did not rename the 'old' to 'new' so the patch showed cdsConstants.cpp as a 'new' file. So I will change description as you indicated. Thanks

?? I'd rather you try again and do a rename :) Otherwise please advise
what, if any, changes were actually made to the "new" file?

Thanks,
David

[yminqi]

@dholmes-ora I see your point here --- let me redo the patch using rename.