8273332: [Vector API] C2 fails to check whether the rotate operation is directly supported by the target ISA after JDK-8271366

[DamonFool]

Hi all,

A lot of Vector API tests from Panama's vectorIntrinsics+mask branch crash [1].

This is because arch_supports_vector() fails to check whether the rotate operation is directly supported by the target ISA after JDK-8271366.
It can be fixed by adding Matcher::match_rule_supported_vector check in inline_vector_broadcast_int() and inline_vector_nary_operation() to prevent generation of unsupported rotate operation IR patterns.

Maybe it's hard to reproduce with the jdk-repo, but the bug still be there in theory.
So it would be better to fix it in the jdk repo.

Testing:

• jdk/incubator/vector/ with -ea -esa -Xcomp -XX:CompileThreshold=100, the crash reported in [1] gets fixed with Panama's vectorIntrinsics+mask branch

Thanks.
Best regards,
Jie

[1] https://bugs.openjdk.java.net/browse/JDK-8273205

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273332: [Vector API] C2 fails to check whether the rotate operation is directly supported by the target ISA after JDK-8271366

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5364/head:pull/5364
$ git checkout pull/5364

Update a local copy of the PR:
$ git checkout pull/5364
$ git pull https://git.openjdk.java.net/jdk pull/5364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5364

View PR using the GUI difftool:
$ git pr show -t 5364

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5364.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b28636a4)

[dean-long]

If -ea -esa -Xcomp -XX:CompileThreshold=100 is necessary to reproduce, then shouldn't the tests be updated to test with those flags?

[DamonFool]

If -ea -esa -Xcomp -XX:CompileThreshold=100 is necessary to reproduce, then shouldn't the tests be updated to test with those flags?

It's extremely slow when testing with -ea -esa -Xcomp -XX:CompileThreshold=100.
So it seems not a good idea to add these flags directly in the tests.

Instead, I would suggest adding them in the CI/CD config.
Thanks.

[DamonFool]

After more investigation, this bug won't reproduce in the jdk-repo and should be fixed in Panama's vectorIntrinsics+mask.
Sorry for the noise.