8272863: Replace usages of Collections.sort with List.sort call in public java modules

[turbanoff]

Collections.sort is just a wrapper, so it is better to use an instance method directly.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272863: Replace usages of Collections.sort with List.sort call in public java modules

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5229/head:pull/5229
$ git checkout pull/5229

Update a local copy of the PR:
$ git checkout pull/5229
$ git pull https://git.openjdk.java.net/jdk pull/5229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5229

View PR using the GUI difftool:
$ git pr show -t 5229

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5229.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following labels will be automatically applied to this pull request:

• 2d
• awt
• core-libs
• i18n
• net
• security
• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mrserb]

The changes in the src/java.desktop/ looks fine.

[mrserb]

Filed: https://bugs.openjdk.java.net/browse/JDK-8272863

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272863: Replace usages of Collections.sort with List.sort call in public java modules

Reviewed-by: serb, dfuchs, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 2ef6871: 8272447: Remove 'native' ranked Mutex
• 63e062f: 8236176: Parallel GC SplitInfo comment should be updated for shadow regions
• c5a2712: 8272850: Drop zapping values in the Zap* option descriptions
• 1e3e333: 8272884: Make VoidClosure::do_void pure virtual
• 0f428ca: 8272570: C2: crash in PhaseCFG::global_code_motion
• b17b821: 8272639: jpackaged applications using microphone on mac
• 0e7288f: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions
• 6ace805: 8272856: DoubleFlagWithIntegerValue uses G1GC-only flag
• c547ead: 8272916: Copyright year was modified unintentionally in jlink.properties and ImagePluginStack.java
• aaedac6: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/709b5910c35ad081b2367435cbc689414098b87a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @dfuch, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (e31936a5)
• 01: Full - Incremental (d6dfc8bf)
• 00: Full (e31936a5)

[dfuch]

java/net and sun/net changes LGTM

[azvegint]

There are a bunch of calls to Collections.sort() without a comparator specified (at least in java.desktop):

https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/java2d/Spans.java#L144
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/awt/DebugSettings.java#L278
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java#L787
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/DefaultRowSorter.java#L1070
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/DefaultRowSorter.java#L1204
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/GroupLayout.java#L2137

It is also a wrapper to list.sort(null).

Is there any reason to not touch them along with this fix?

[naotoj]

java.time changes look good.

[turbanoff]

Is there any reason to not touch them along with this fix?

Update them too.

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version e31936a) is now ready to be sponsored by a Committer.

[mrserb]

/sponsor

[openjdk]

Going to push as commit d732c30.
Since your change was applied there have been 37 commits pushed to the master branch:

• fe7d708: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
• 845e1ce: 8272983: G1 Add marking details to eager reclaim logging
• c420530: 8272481: [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java fails
• e43a907: 8271315: Redo: Nimbus JTree renderer properties persist across L&F changes
• 11c9fd8: 8272975: ParallelGC: add documentation to heap memory layout
• b94fd32: 8272859: Javadoc external links should only have feature version number in URL
• 9166ba3: 8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop
• 49b2789: 8262751: RenderPipelineState assertion error in J2DDemo
• a3308af: 8272836: Limit run time for java/lang/invoke/LFCaching tests
• c4c76e2: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
• ... and 27 more: https://git.openjdk.java.net/jdk/compare/709b5910c35ad081b2367435cbc689414098b87a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb @turbanoff Pushed as commit d732c30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.