Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225082: Remove IdenTrust certificate that is expiring in September 2021 #4851

Closed
wants to merge 1 commit into from
Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jul 21, 2021

This CA had no code signing certificates issued so it is safe to remove it from cacerts truststore.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8225082: Remove IdenTrust certificate that is expiring in September 2021

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4851/head:pull/4851
$ git checkout pull/4851

Update a local copy of the PR:
$ git checkout pull/4851
$ git pull https://git.openjdk.java.net/jdk pull/4851/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4851

View PR using the GUI difftool:
$ git pr show -t 4851

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4851.diff

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2021
@openjdk
Copy link

openjdk bot commented Jul 21, 2021

@rhalade The following labels will be automatically applied to this pull request:

  • build
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org labels Jul 21, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean removal to me. Approving so this can be backported to JDK Updates that would be after the cert expiry date.

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225082: Remove IdenTrust certificate that is expiring in September 2021

Reviewed-by: shade, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 90 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2021
@rhalade
Copy link
Member Author

rhalade commented Jul 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

Going to push as commit 2ec45dc.
Since your change was applied there have been 126 commits pushed to the master branch:

  • 25f00d7: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers
  • 41b4c19: 8271353: PerfDataManager::destroy crashes in VM_Exit
  • 357947a: 8270061: Change parameter order of ResourceHashtable
  • 034788a: 8270925: replay dump using CICrashAt does not include inlining data
  • 9711033: 8209776: Refactor jdk/security/JavaDotSecurity/ifdefs.sh to plain java test
  • 60c11fe: 8261088: Repeatable annotations without @target cannot have containers that target module declarations
  • dcdb1b6: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • a066c7b: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • 072fe48: 8270901: Typo PHASE_CPP in CompilerPhaseType
  • d7b5cb6: 8271368: [BACKOUT] JDK-8266054 VectorAPI rotate operation optimization
  • ... and 116 more: https://git.openjdk.java.net/jdk/compare/38694aa970be73d269cb444ea80ebe7085bd9e90...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@rhalade Pushed as commit 2ec45dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8225082 branch July 29, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

3 participants