Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream #4607

Closed
wants to merge 15 commits into from
+356 −6
Closed

8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream #4607

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8d6f340
8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a n…
jaikiran Jun 27, 2021
127acbc
add @requires to the new test to selectively decide where the test runs
jaikiran Jun 28, 2021
19cc9d4
minor summary update on test
jaikiran Jun 30, 2021
f519aa4
an initial proposed test for testing compressed size entry greater th…
jaikiran Jun 30, 2021
5c5f269
Introduce a way to allow outputstream returned by ZipOutputStream to …
jaikiran Jul 2, 2021
a9dfd8c
propagate back the original checked IOException to the callers
jaikiran Jul 4, 2021
c27a0a4
Implement Alan's review suggestion - don't expose the threshold as a …
jaikiran Jul 5, 2021
9de70ef
use jtreg's construct of manual test
jaikiran Jul 5, 2021
50e64d7
remove no longer used constant
jaikiran Jul 5, 2021
0fdbcea
minor update to comment on FileRolloverOutputStream class
jaikiran Jul 5, 2021
c1ec9e1
reorganize the tests now that the temp file creation threshold isn't …
jaikiran Jul 5, 2021
b6d453f
review suggestion - wrap ByteArrayOutputStream instead of extending it
jaikiran Jul 22, 2021
90101d4
remove no longer necessary javadoc comment on test
jaikiran Jul 22, 2021
9e78ba0
Implement review suggestions:
jaikiran Jul 23, 2021
991de6b
Merge latest from master branch
jaikiran Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/jdk/jdk/nio/zipfs/LargeEntrySizeTest.java
View file
Original file line number Diff line number Diff line change
@@ -44,7 +44,8 @@
* @test
* @bug 8190753
* @summary Verify that opening an outputstream for a large zip entry doesn't run into "Negative initial size" exception
* @run testng LargeEntrySizeTest
* @requires (sun.arch.data.model == "64" & os.maxMemory >= 5g)
* @run testng/othervm -Xmx4g LargeEntrySizeTest
*/
public class LargeEntrySizeTest {