8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 #4601

asgibbons · 2021-06-26T14:39:53Z

Enhance the Base64 Encode intrinsic for x86 using AVX-512 to get better performance. Also allow for performance improvement on non-AVX-512 enabled platforms.

Added AVX-512 code for encoding Base64 blocks, including slight improvements for non-AVX-512 x86 platforms.

Running the Base64Decode benchmark, this change increases decode performance by an average of 2.6x with a maximum 9.7x for buffers > ~20k. The numbers are given in the table below.

Base Score is without intrinsic support, Optimized Score is using this intrinsic, and Gain is Base / Optimized.

Benchmark Name	Base Score	Optimized Score	Gain
testBase64Encode size 1	8.10	8.04	1.01
testBase64Encode size 2	8.51	8.43	1.01
testBase64Encode size 3	11.08	10.72	1.03
testBase64Encode size 6	13.98	13.12	1.07
testBase64Encode size 7	14.44	13.38	1.08
testBase64Encode size 9	15.44	14.37	1.07
testBase64Encode size 10	16.13	14.97	1.08
testBase64Encode size 48	27.14	23.23	1.17
testBase64Encode size 512	123.86	30.75	4.03
testBase64Encode size 1000	224.42	37.71	5.95
testBase64Encode size 20000	4202.11	430.16	9.77

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8269404: Base64 Encoding optimization enhancements for x86 using AVX-512

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to c4cbe97
Sandhya Viswanathan (@sviswa7 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4601/head:pull/4601
$ git checkout pull/4601

Update a local copy of the PR:
$ git checkout pull/4601
$ git pull https://git.openjdk.java.net/jdk pull/4601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4601

View PR using the GUI difftool:
$ git pr show -t 4601

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4601.diff

bridgekeeper · 2021-06-26T14:40:01Z

👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

asgibbons · 2021-06-26T14:42:32Z

/label add hotspot-compiler

openjdk · 2021-06-26T14:42:56Z

@asgibbons The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2021-06-26T14:43:12Z

@asgibbons The hotspot-compiler label was already applied.

mlbridge · 2021-06-26T14:46:16Z

Webrevs

vnkozlov · 2021-06-26T15:07:43Z

@asgibbons if you are still working on this, please convert it to draft PR. There is Convert to draft link under Reviewers:

Reviewers
No reviews
Still in progress? Convert to draft

Otherwise it seems like it is ready for review and we got RFR emails.

asgibbons · 2021-06-26T16:42:37Z

Thanks, @vnkozlov. I have tested this on all the platforms I have available to me, and it has been internally reviewed. I'm a novice when it comes to this process and I have read the contributing guidelines, but I'm at a loss as to how draft PRs are used.

I believe this is the change that will ultimately be integrated, so in fact I am looking for reviews. Can you enlighten me please?

vnkozlov

At first I thought you would add more changes in Java lib and Hotspot runtime.
But you simply optimized assembler code for existing Encode intrinsic.

This looks good to me but I need to test it.

vnkozlov · 2021-06-27T01:54:41Z

compiler/intrinsics/base64/TestBase64.java failed with wrong result on Windows (avx512):

----------System.out:(1/17)----------
5000 iterations
----------System.err:(17/1502)----------
java.lang.RuntimeException: Assertion failed! The result is not same as expected
 result: ICAgICAgICAxNiBRICAgICAgICAgICAgsTsA6igAoigAoigAoigAoj0QIHk= expected: ICAgICAgICAxNiBRICAgICAgICAgICAgMzMgaCAgICAgICAgICAgIDUwIHk=
	at compiler.intrinsics.base64.TestBase64.assertEqual(TestBase64.java:238)
	at compiler.intrinsics.base64.TestBase64.test0(TestBase64.java:151)
	at compiler.intrinsics.base64.TestBase64.main(TestBase64.java:72)

asgibbons · 2021-06-28T15:19:52Z

@vnkozlov Looks like I had a shift count wrong for URL encoding. Tested it and it should now work. Sorry for the churn.

vnkozlov

Testing passed.

You need second review.

openjdk · 2021-06-29T20:25:19Z

@asgibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269404: Base64 Encoding optimization enhancements for x86 using AVX-512

Reviewed-by: kvn, sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 248 new commits pushed to the master branch:

ca806ef: 8263531: Remove unused buffer int
7ac0816: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
460c4bb: 8270179: Rename Amalloc_4
375fc2a: 8270009: Factor out and shuffle methods in G1CollectedHeap::do_collection_pause_at_safepoint_helper
6b123b0: Merge
4fc3180: 8266345: (fs) Custom DefaultFileSystemProvider security related loops
999ced0: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
2546006: 8270216: [macOS] Update named used for Java run loop mode
... and 238 more: https://git.openjdk.java.net/jdk/compare/68ef21db415fb61ac9690290b692594da6b87ff9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @sviswa7) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

asgibbons · 2021-07-02T19:32:17Z

/integrate

openjdk · 2021-07-02T19:33:15Z

@asgibbons
Your change (at version c4cbe97) is now ready to be sponsored by a Committer.

src/hotspot/cpu/x86/assembler_x86.cpp

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

asgibbons · 2021-07-10T18:33:38Z

/integrate

openjdk · 2021-07-10T18:34:56Z

@asgibbons
Your change (at version e0db0ae) is now ready to be sponsored by a Committer.

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

asgibbons · 2021-07-13T22:40:51Z

/integrate

openjdk · 2021-07-13T22:41:41Z

@asgibbons
Your change (at version 10ec992) is now ready to be sponsored by a Committer.

sviswa7 · 2021-07-13T23:14:34Z

The patch looks good to me.

sviswa7 · 2021-07-13T23:50:52Z

/sponsor

openjdk · 2021-07-13T23:52:17Z

Going to push as commit 9cac94d.
Since your change was applied there have been 248 commits pushed to the master branch:

ca806ef: 8263531: Remove unused buffer int
7ac0816: 8269897: Shenandoah: Resolve UNKNOWN access strength, where possible
460c4bb: 8270179: Rename Amalloc_4
375fc2a: 8270009: Factor out and shuffle methods in G1CollectedHeap::do_collection_pause_at_safepoint_helper
6b123b0: Merge
4fc3180: 8266345: (fs) Custom DefaultFileSystemProvider security related loops
999ced0: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
e1d3e73: 8268965: TCP Connection Reset when connecting simple socket to SSL server
3d82b0e: 8269558: fix of JDK-8252657 missed to update history at the end of JVM TI spec
2546006: 8270216: [macOS] Update named used for Java run loop mode
... and 238 more: https://git.openjdk.java.net/jdk/compare/68ef21db415fb61ac9690290b692594da6b87ff9...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-13T23:52:32Z

@sviswa7 @asgibbons Pushed as commit 9cac94d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

asgibbons · 2022-11-10T00:55:54Z

/backport jdk17u-dev

openjdk · 2022-11-10T00:56:29Z

@asgibbons Only OpenJDK contributors can use the /backport command

sviswa7 · 2022-11-10T01:07:54Z

/backport jdk17u-dev

openjdk · 2022-11-10T01:10:34Z

@sviswa7 the backport was successfully created on the branch sviswa7-backport-9cac94d5 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9cac94d5 from the openjdk/jdk repository.

The commit being backported was authored by Scott Gibbons on 13 Jul 2021 and was reviewed by Vladimir Kozlov and Sandhya Viswanathan.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev sviswa7-backport-9cac94d5:sviswa7-backport-9cac94d5
$ git checkout sviswa7-backport-9cac94d5
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev sviswa7-backport-9cac94d5

asgibbons added 8 commits June 25, 2021 15:03

First cut at Base64 Encoder.

8c2859b

Adding forgotten assembly instructions.

7b81d92

Adding forgotten assembly instructions.

cfd8158

Adding forgotten assembly instructions.

3e678ce

Formatting change; forgotten removal of add to dp.

119b4cc

Revert name change for decode.

810c662

Windows build warnings removal.

3216ffc

Whitespace cleanup.

381b6b5

openjdk bot added the rfr label Jun 26, 2021

openjdk bot added the hotspot-compiler label Jun 26, 2021

Format warning removal.

f7d63f6

vnkozlov reviewed Jun 26, 2021

View reviewed changes

Wrong shift count for URL encoding.

c4cbe97

vnkozlov approved these changes Jun 29, 2021

View reviewed changes

openjdk bot added the ready label Jun 29, 2021

openjdk bot added the sponsor label Jul 2, 2021

sviswa7 reviewed Jul 10, 2021

View reviewed changes

Addressing review comments.

e0db0ae

openjdk bot removed the sponsor label Jul 10, 2021

openjdk bot added the sponsor label Jul 10, 2021

jatin-bhateja reviewed Jul 11, 2021

View reviewed changes

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Show resolved Hide resolved

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Show resolved Hide resolved

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Show resolved Hide resolved

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Show resolved Hide resolved

Fix error detection for decodeBlock.

10ec992

openjdk bot removed the sponsor label Jul 13, 2021

openjdk bot added the sponsor label Jul 13, 2021

sviswa7 approved these changes Jul 13, 2021

View reviewed changes

openjdk bot closed this Jul 13, 2021

openjdk bot added integrated and removed ready rfr sponsor labels Jul 13, 2021

asgibbons deleted the base64_encode_new branch July 13, 2021 23:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 #4601

8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 #4601

asgibbons commented Jun 26, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jun 26, 2021

asgibbons commented Jun 26, 2021

openjdk bot commented Jun 26, 2021

openjdk bot commented Jun 26, 2021

mlbridge bot commented Jun 26, 2021 •

edited

Loading

vnkozlov commented Jun 26, 2021

asgibbons commented Jun 26, 2021

vnkozlov left a comment •

edited

Loading

vnkozlov commented Jun 27, 2021

asgibbons commented Jun 28, 2021

vnkozlov left a comment

openjdk bot commented Jun 29, 2021 •

edited

Loading

asgibbons commented Jul 2, 2021

openjdk bot commented Jul 2, 2021

asgibbons commented Jul 10, 2021

openjdk bot commented Jul 10, 2021

asgibbons commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

sviswa7 commented Jul 13, 2021

sviswa7 commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

asgibbons commented Nov 10, 2022

openjdk bot commented Nov 10, 2022

sviswa7 commented Nov 10, 2022

openjdk bot commented Nov 10, 2022

8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 #4601

8269404: Base64 Encoding optimization enhancements for x86 using AVX-512 #4601

Conversation

asgibbons commented Jun 26, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jun 26, 2021

asgibbons commented Jun 26, 2021

openjdk bot commented Jun 26, 2021

openjdk bot commented Jun 26, 2021

mlbridge bot commented Jun 26, 2021 • edited Loading

Webrevs

vnkozlov commented Jun 26, 2021

asgibbons commented Jun 26, 2021

vnkozlov left a comment • edited Loading

Choose a reason for hiding this comment

vnkozlov commented Jun 27, 2021

asgibbons commented Jun 28, 2021

vnkozlov left a comment

Choose a reason for hiding this comment

openjdk bot commented Jun 29, 2021 • edited Loading

asgibbons commented Jul 2, 2021

openjdk bot commented Jul 2, 2021

asgibbons commented Jul 10, 2021

openjdk bot commented Jul 10, 2021

asgibbons commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

sviswa7 commented Jul 13, 2021

sviswa7 commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

openjdk bot commented Jul 13, 2021

asgibbons commented Nov 10, 2022

openjdk bot commented Nov 10, 2022

sviswa7 commented Nov 10, 2022

openjdk bot commented Nov 10, 2022

asgibbons commented Jun 26, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Jun 26, 2021 •

edited

Loading

vnkozlov left a comment •

edited

Loading

openjdk bot commented Jun 29, 2021 •

edited

Loading