8268328: Upstream: 8267989: Exceptions thrown during upcalls should be handled (Pt. 1)

[JornVernee]

Hi,

This is part 1 of a two part upstreaming process of the patch mentioned in the subject line. The patch was split into 2 in order to document 2 separate specification changes that arose from a change in the implementation, with 2 separate CSRs.

This patch changes the handling of method handles that might throw checked exceptions, by the var handle combinators found in jdk.incubator.foreign.MemoryHandles. Particularly, it makes the check more lenient towards BoundMethodHandles that have fields that are method handles that might themselves throw exceptions, since it is not known whether the enclosing method handle catches such exceptions. For instance, if a target method handle is wrapped using the catchException combinator, which handles all exceptions thrown by that target, the current code will still reject such method handles, even though no checked exceptions can be thrown.

The patch fixes this by instead wrapping method handles for which it is not possible to eagerly determine whether they throw exception using the catchException combinator, with an exception handler that catches checked exceptions and instead throws an IllegalStateException with the original exception as the cause. (See also the CSR).

The main motivation for doing this is having the ability to share the implementation with the CLinker::upcallStub API, which also wants to eagerly reject method handles that are determined to throw exceptions.

See also the original review for the panama-foreign repo: openjdk/panama-foreign#543

Thanks,
Jorn

Testing: jdk_foreign test suite.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Integration blocker

 ⚠️ The change requires a CSR request to be approved.

Issue

• JDK-8268328: Upstream: 8267989: Exceptions thrown during upcalls should be handled (Pt. 1)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4395/head:pull/4395
$ git checkout pull/4395

Update a local copy of the PR:
$ git checkout pull/4395
$ git pull https://git.openjdk.java.net/jdk pull/4395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4395

View PR using the GUI difftool:
$ git pr show -t 4395

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4395.diff

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JornVernee The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[JornVernee]

/label remove security

[JornVernee]

/csr

[openjdk]

@JornVernee
The security label was successfully removed.

[openjdk]

@JornVernee this pull request will not be integrated until the CSR request JDK-8268336 for issue JDK-8268328 has been approved.

[mlbridge]

Webrevs

• 00: Full (656a1704)

[JornVernee]

Deferred until a better solution is available.