Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266078: Reader.read(CharBuffer) advances Reader position for read-only Charbuffers #3725

Closed
wants to merge 3 commits into from
+71 −0
Closed

8266078: Reader.read(CharBuffer) advances Reader position for read-only Charbuffers #3725

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fbaff7
8266078: Reader.read(CharBuffer) advances Reader position for read-on…
bplb Apr 27, 2021
4a899b2
8266078: Make read-only check global; add message in test
bplb Apr 27, 2021
8935981
8266078: Remove confusing comment
bplb Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/java.base/share/classes/java/io/Reader.java
View file
Original file line number Diff line number Diff line change
@@ -202,8 +202,6 @@ public int read(CharBuffer target) throws IOException {
} else {
int len = target.remaining();
char[] cbuf = new char[len];
// If a read-only check had not been done above, then
// the stream would be incorrectly advanced here.
nread = read(cbuf, 0, len);
if (nread > 0)
target.put(cbuf, 0, nread);