Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265348: Shenandoah: Use timed wait to sleep control thread #3547

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 16, 2021

I would like to bring the patch with the same synopsis from Shenandoah repo [1] to mainline, it should help what I am working on.

Test:

  • hotspot_gc_shenandoah

[1] openjdk/shenandoah#28


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265348: Shenandoah: Use timed wait to sleep control thread

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3547/head:pull/3547
$ git checkout pull/3547

Update a local copy of the PR:
$ git checkout pull/3547
$ git pull https://git.openjdk.java.net/jdk pull/3547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3547

View PR using the GUI difftool:
$ git pr show -t 3547

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3547.diff

Sorry, something went wrong.

@zhengyu123
Copy link
Contributor Author

add author @earthling-amzn

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Apr 16, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2021

Webrevs

@shipilev
Copy link
Member

Wait, there are questions about lock ranking. I wanted to address it in https://bugs.openjdk.java.net/browse/JDK-8264851.

@zhengyu123
Copy link
Contributor Author

Wait, there are questions about lock ranking. I wanted to address it in https://bugs.openjdk.java.net/browse/JDK-8264851.

I did not realize JDK-8264851. I am closing this as duplicate.

@zhengyu123 zhengyu123 closed this Apr 16, 2021
@zhengyu123 zhengyu123 deleted the JDK-8265348-control-timed-wait branch July 19, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

2 participants