Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264609 : Number.{byteValue, shortValue} spec should use @implSpec #3314

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 1, 2021

Please review this small code change and its accompanying CSR:

https://bugs.openjdk.java.net/browse/JDK-8264610


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264609: Number.{byteValue, shortValue} spec should use @implSpec

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3314/head:pull/3314
$ git checkout pull/3314

Update a local copy of the PR:
$ git checkout pull/3314
$ git pull https://git.openjdk.java.net/jdk pull/3314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3314

View PR using the GUI difftool:
$ git pr show -t 3314

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3314.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jddarcy
Copy link
Member Author

jddarcy commented Apr 1, 2021

/csr needed

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Apr 1, 2021
@openjdk
Copy link

openjdk bot commented Apr 1, 2021

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@jddarcy please create a CSR request and add link to it in JDK-8264610. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented Apr 1, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 1, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2021

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSR also reviewed.

@jddarcy jddarcy changed the title 8264610: Number.{byteValue, shortValue} spec should use @implSpec 8264609 : Number.{byteValue, shortValue} spec should use @implSpec Apr 1, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Apr 1, 2021

/csr unneeded

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 1, 2021
@openjdk
Copy link

openjdk bot commented Apr 1, 2021

@jddarcy determined that a CSR request is not needed for this pull request.

@jddarcy
Copy link
Member Author

jddarcy commented Apr 1, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264609: Number.{byteValue, shortValue} spec should use @implSpec

Reviewed-by: psandoz, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5858399: 8264285: Clean the modification of ccstr JVM flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 1, 2021
@openjdk openjdk bot closed this Apr 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2021
@openjdk
Copy link

openjdk bot commented Apr 1, 2021

@jddarcy Since your change was applied there has been 1 commit pushed to the master branch:

  • 5858399: 8264285: Clean the modification of ccstr JVM flags

Your commit was automatically rebased without conflicts.

Pushed as commit b953386.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8264609 branch June 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants