Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 #3304

Closed
wants to merge 2 commits into from
+6 −12
Closed

8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28 #3304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515bba9
8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
Apr 1, 2021
3b6be82
Remove dead code
Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/java.base/share/native/libjimage/imageFile.cpp
View file
Original file line number Diff line number Diff line change
@@ -211,23 +211,6 @@ ImageFileReaderTable::ImageFileReaderTable() : _count(0), _max(_growth) {
assert(_table != NULL && "allocation failed");
}

ImageFileReaderTable::~ImageFileReaderTable() {
// Bug 8166727
//
// WARNING: Should never close the jimage file.
// Threads may still be running at shutdown.
#if 0
for (u4 i = 0; i < _count; i++) {
ImageFileReader* image = _table[i];

if (image != NULL) {
delete image;
}
}
free(_table);
#endif
}

// Add a new image entry to the table.
void ImageFileReaderTable::add(ImageFileReader* image) {
if (_count == _max) {
7 changes: 6 additions & 1 deletion src/java.base/share/native/libjimage/imageFile.hpp
View file
Original file line number Diff line number Diff line change
@@ -371,7 +371,12 @@ class ImageFileReaderTable {

public:
ImageFileReaderTable();
~ImageFileReaderTable();
// ~ImageFileReaderTable()
// Bug 8166727
//
// WARNING: Should never close jimage files.
// Threads may still be running during shutdown.
//

// Return the number of entries.
inline u4 count() { return _count; }