JDK-8264454 : Jaxp unit test from open jdk needs to be improved #3274

mahendrachhipa · 2021-03-30T16:56:57Z

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8264454: Jaxp unit test from open jdk needs to be improved

Reviewers

Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3274/head:pull/3274
$ git checkout pull/3274

Update a local copy of the PR:
$ git checkout pull/3274
$ git pull https://git.openjdk.java.net/jdk pull/3274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3274

View PR using the GUI difftool:
$ git pr show -t 3274

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3274.diff

https://bugs.openjdk.java.net/browse/JDK-8064681

https://bugs.openjdk.java.net/browse/JDK-8264454

bridgekeeper · 2021-03-30T16:57:11Z

👋 Welcome back mahendrachhipa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-03-30T16:59:19Z

@mahendrachhipa The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-03-30T17:04:32Z

Webrevs

JoeWang-Java · 2021-03-31T04:19:46Z

test/jaxp/javax/xml/jaxp/unittest/common/Bug6350682.java

-        } catch (Exception e) {
-            e.printStackTrace();
-            Assert.fail("Exception occured: " + e.getMessage());
+        runWithAllPerm(() -> Thread.currentThread().setContextClassLoader(null));


To address item 4 (the environment is changed), a note, something like "this test runs in othervm" can be added here or to the summary.

Added the comment

JoeWang-Java · 2021-03-31T04:28:54Z

test/jaxp/javax/xml/jaxp/unittest/common/Bug6723276Test.java


    @Test
-    public void test1() {
+    public void testSAXParserFactoryCreationWithDefaultContextClassLoader() {


A shorter name such as testWithDefaultClassLoader would be fine.

JoeWang-Java · 2021-03-31T04:28:58Z

test/jaxp/javax/xml/jaxp/unittest/common/Bug6723276Test.java

@@ -41,27 +42,28 @@
 */
 @Listeners({jaxp.library.BasePolicy.class})
 public class Bug6723276Test {
+    private static final String ERR_MSG = "org.apache.xerces.jaxp.SAXParserFactoryImpl not found";


This test currently doesn't verify anything since there's no org.apache.xerces.jaxp.SAXParserFactoryImpl on the classpath. Post JDK 9, such test would require creating a dummy module.

JoeWang-Java · 2021-03-31T04:29:28Z

test/jaxp/javax/xml/jaxp/unittest/common/Bug6723276Test.java

                Assert.fail(e.getMessage());
            }
        }
    }

    @Test
-    public void test2() {
+    public void testSAXParserFactoryCreationWithGivenURLContextClassLoader() {


A shorter name would be testWithURLClassLoader

JoeWang-Java · 2021-03-31T04:32:10Z

test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6320118.java

+        Assert.assertEquals(calendar.getYear(), 1970);
+        Assert.assertEquals(calendar.getMonth(), 1);
+        Assert.assertEquals(calendar.getDay(), 2);
+        Assert.assertEquals(calendar.getHour(), 0, "hour 24 needs to be treated as hour 0 of next day");


This change has added assertions, but it seems ok.

JoeWang-Java · 2021-03-31T04:54:31Z

test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6937964Test.java

@@ -56,7 +57,7 @@
    private static final String TEST_VALUE_FAIL = "*FAIL*";


I don't see this in the expected values. It, along with the related assertions, may be removed.

JoeWang-Java · 2021-03-31T05:01:44Z

test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6937964Test.java

-                if (!TEST_VALUES_LEXICAL[onTestValue + 1].equals(duration.toString())) {
-                    Assert.fail("Duration created with \"" + TEST_VALUES_LEXICAL[onTestValue] + "\" was expected to be \""
-                            + TEST_VALUES_LEXICAL[onTestValue + 1] + "\" and has the value \"" + duration.toString() + "\"");
+                if (!expectedLex.equals(duration.toString())) {


Can be changed to assertEquals

JoeWang-Java · 2021-03-31T05:02:31Z

test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6937964Test.java

+            // for now due to a bug
+            try {
+                QName xmlSchemaType = duration.getXMLSchemaType();
+                if (!xmlSchemaType.equals(DatatypeConstants.DURATION_YEARMONTH)) {


Can be changed to assertEquals

JoeWang-Java · 2021-03-31T05:04:31Z

test/jaxp/javax/xml/jaxp/unittest/datatype/Bug6937964Test.java

                                + DatatypeConstants.DURATION_YEARMONTH + "\" and has the value \"" + duration.toString() + "\"");
-                    }
+                }
                } catch (IllegalStateException illegalStateException) {
                    // TODO; this test really should pass
                    System.err.println("Please fix this bug that is being ignored, for now: " + illegalStateException.getMessage());


Do we still have such a bug?

Yes, test is still trowing IllegalStateException.

JoeWang-Java · 2021-04-08T00:15:15Z

Ok, this is enough of improvement for now. I created a bug to keep track of the ISE case.

openjdk · 2021-04-08T00:18:44Z

@mahendrachhipa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264454: Jaxp unit test from open jdk needs to be improved

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 394 new commits pushed to the master branch:

ec599da: 8264633: Add missing logging to PlatformRecording#stop
e89542f: 8264352: AArch64: Optimize vector "not/andNot" for NEON and SVE
016db40: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to
78d1164: 8214455: Relocate CDS archived regions to the top of the G1 heap
88eb291: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr
a863ab6: 8264551: Unexpected warning when jpackage creates an exe
6e2b82a: 8264731: Introduce InstanceKlass::method_at_itable_or_null()
22b20f8: 8264424: Support OopStorage bulk allocation
ab3be72: 8264863: Update JCov version to support JDK 17
774e5ae: 8264742: member variable _monitor of MonitorLocker is redundant
... and 384 more: https://git.openjdk.java.net/jdk/compare/0ea48d9d65e9c56e6646f799e49337cfd9df676b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mahendrachhipa · 2021-04-08T08:18:33Z

/integrate

openjdk · 2021-04-08T08:21:56Z

@mahendrachhipa
Your change (at version 002bdff) is now ready to be sponsored by a Committer.

JoeWang-Java · 2021-04-08T16:08:24Z

/sponsor

msheppar · 2021-04-08T16:49:19Z

/sponsor

openjdk · 2021-04-08T21:22:50Z

@JoeWang-Java @mahendrachhipa Since your change was applied there have been 401 commits pushed to the master branch:

5bd6c74: 8236127: Use value of --icon CLI option to set icon for exe installers
81d35e4: 8264063: Outer Safepoint poll load should not reference the head of inner strip mined loop.
04fa1ed: 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch
214d6e2: 8263506: Make sun.net.httpserver.UnmodifiableHeaders unmodifiable
af13c64: 8264711: More runtime TRAPS cleanups
3aec2d9: 8264718: Shenandoah: enable string deduplication during root scanning
255afbe: 8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out
ec599da: 8264633: Add missing logging to PlatformRecording#stop
e89542f: 8264352: AArch64: Optimize vector "not/andNot" for NEON and SVE
016db40: 8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to
... and 391 more: https://git.openjdk.java.net/jdk/compare/0ea48d9d65e9c56e6646f799e49337cfd9df676b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 308f679.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2021-04-08T21:41:07Z

@msheppar The command sponsor can only be used in open pull requests.

mahendrachhipa added 2 commits March 22, 2021 10:19

JDK-8064681 : Jaxp unit test need to be improved

a6a0cce

https://bugs.openjdk.java.net/browse/JDK-8064681

JDK-8264454 : Jaxp unit test from open jdk needs to be improved

2775a64

https://bugs.openjdk.java.net/browse/JDK-8264454

openjdk bot added core-libs rfr labels Mar 30, 2021

JoeWang-Java reviewed Mar 31, 2021

View reviewed changes

mahendrachhipa added 2 commits April 6, 2021 17:41

Implemented the review comments.

3f25889

Updated copyright year.

002bdff

JoeWang-Java approved these changes Apr 8, 2021

View reviewed changes

openjdk bot added the ready label Apr 8, 2021

openjdk bot added the sponsor label Apr 8, 2021

openjdk bot closed this Apr 8, 2021

openjdk bot added integrated and removed sponsor ready rfr labels Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8264454 : Jaxp unit test from open jdk needs to be improved #3274

JDK-8264454 : Jaxp unit test from open jdk needs to be improved #3274

mahendrachhipa commented Mar 30, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

mlbridge bot commented Mar 30, 2021 •

edited

Loading

JoeWang-Java Mar 31, 2021 •

edited

Loading

mahendrachhipa Apr 6, 2021

JoeWang-Java Mar 31, 2021

JoeWang-Java Mar 31, 2021

JoeWang-Java Mar 31, 2021

JoeWang-Java Mar 31, 2021

JoeWang-Java Mar 31, 2021

JoeWang-Java Mar 31, 2021

mahendrachhipa Apr 6, 2021

JoeWang-Java Mar 31, 2021

JoeWang-Java Mar 31, 2021

mahendrachhipa Apr 6, 2021

JoeWang-Java commented Apr 8, 2021

openjdk bot commented Apr 8, 2021 •

edited

Loading

mahendrachhipa commented Apr 8, 2021

openjdk bot commented Apr 8, 2021

JoeWang-Java commented Apr 8, 2021

msheppar commented Apr 8, 2021

openjdk bot commented Apr 8, 2021

openjdk bot commented Apr 8, 2021

		@@ -56,7 +57,7 @@
		private static final String TEST_VALUE_FAIL = "FAIL";

JDK-8264454 : Jaxp unit test from open jdk needs to be improved #3274

JDK-8264454 : Jaxp unit test from open jdk needs to be improved #3274

Conversation

mahendrachhipa commented Mar 30, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 30, 2021

openjdk bot commented Mar 30, 2021

mlbridge bot commented Mar 30, 2021 • edited Loading

Webrevs

JoeWang-Java Mar 31, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeWang-Java commented Apr 8, 2021

openjdk bot commented Apr 8, 2021 • edited Loading

mahendrachhipa commented Apr 8, 2021

openjdk bot commented Apr 8, 2021

JoeWang-Java commented Apr 8, 2021

msheppar commented Apr 8, 2021

openjdk bot commented Apr 8, 2021

openjdk bot commented Apr 8, 2021

mahendrachhipa commented Mar 30, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 30, 2021 •

edited

Loading

JoeWang-Java Mar 31, 2021 •

edited

Loading

openjdk bot commented Apr 8, 2021 •

edited

Loading