JDK-8263871: On sem_destroy() failing we should assert

[tstuefe]

This is rather trivial.

We use anonymous Posix semaphores for some synchronization in hotspot. sem_destroy() can fail on some platforms with EBUSY if the semaphore has outstanding waiters. The glibc does not care, will happily wipe the sem_t structure and report success. But other Unices care (eg BSD, AIX, HP-UX) and refuse to close the semaphore, leaving the sem_t structure untouched.

It then happened for us that a new semaphore was created at the exact location of the old, still unclosed semaphore, and the unchanged sem_t structure was fed to sem_init(), which would fail with the same EBUSY error and trigger a guarantee.

One simple thing we should do is to assert success after closing a semaphore, as we do on all other semaphore operations. Granted, we won't see anything on Linux with glibc, but maybe shake loose errors on other platforms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263871: On sem_destroy() failing we should assert

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3089/head:pull/3089
$ git checkout pull/3089

To update a local copy of the PR:
$ git checkout pull/3089
$ git pull https://git.openjdk.java.net/jdk pull/3089/head

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dd5c16c)

[dholmes-ora]

Looks good and trivial.

I just hope we don't find sem_destroy has been silently failing :)

Thanks,
David

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263871: On sem_destroy() failing we should assert

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 96e5c3f: 8263890: Broken links to Unicode.org
• 4d9517d: 8263834: Work around gdb for HashtableEntry
• 6fa6557: 8263825: Remove unused and commented out member from NTLMException
• 77ebc11: 8263892: More modifier order fixes in java.base
• 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
• 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
• 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
• 0b5216a: 8263545: Convert jpackage to use Stream.toList()
• ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
• 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/b49c5893409879bbfecbf60127a512bcc48d087c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Looks good and trivial.

I just hope we don't find sem_destroy has been silently failing :)

Thanks,
David

Thanks David! I hope so too.

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 11 commits pushed to the master branch:

• 96e5c3f: 8263890: Broken links to Unicode.org
• 4d9517d: 8263834: Work around gdb for HashtableEntry
• 6fa6557: 8263825: Remove unused and commented out member from NTLMException
• 77ebc11: 8263892: More modifier order fixes in java.base
• 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
• 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
• 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
• 0b5216a: 8263545: Convert jpackage to use Stream.toList()
• ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
• 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/b49c5893409879bbfecbf60127a512bcc48d087c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5b8233b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.