Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die #2998

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Mar 14, 2021

A trivial refactoring with zero functional changes.

The runtime exit code (os::shutdown, os::abort and os::die) on POSIX platforms is almost identical - Linux has one extra action in os::abort. This code should be shared via os_posix.cpp (note os::exit is already shared via os_posix.inline.hpp).

Testing:

  • GHA
  • Tiers 1-3

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2998/head:pull/2998
$ git checkout pull/2998

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2021
@openjdk
Copy link

openjdk bot commented Mar 14, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 14, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2021
@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2021
@dholmes-ora dholmes-ora deleted the 8263564 branch March 15, 2021 02:03
@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@dholmes-ora Pushed as commit 554dd29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants