Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253455: Record Classes javax.lang.model changes #291

Closed
wants to merge 6 commits into from
+18 −139
Closed

8253455: Record Classes javax.lang.model changes #291

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd971e2
8253455: Record Classes (final) javax.lang.model changes
vicente-romero-oracle Sep 21, 2020
f0845f6
adding reminder to remove RECORDS from PreviewFeature
vicente-romero-oracle Sep 29, 2020
aeb799f
this test will be fixed in the patch for JDK-8246774
vicente-romero-oracle Sep 29, 2020
f5682fc
adding a comment to PreviewFeature.Feature
vicente-romero-oracle Sep 29, 2020
cd27384
updating @since from 14 to 16
vicente-romero-oracle Oct 9, 2020
a037310
updating comment syntax for Feature.RECORDS
vicente-romero-oracle Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions test/langtools/tools/javac/processing/model/element/JavaxLangModelForRecords.java
View file
Original file line number Diff line number Diff line change
@@ -105,13 +105,17 @@ public void testQualifiedClassForProcessing(Path base) throws Exception {
tb.writeJavaFiles(r,
"record R(int i) {}");

List<String> expected = List.of(
"Note: field: i",
"Note: record component: i");
List<String> expected = List.of("Note: field: i",
"Note: record component: i",
"Note: testQualifiedClassForProcessing" + File.separator + "src" + File.separator
+ "R" + File.separator + "R.java uses preview language features.",
"Note: Recompile with -Xlint:preview for details.");

for (Mode mode : new Mode[] {Mode.API}) {
List<String> log = new JavacTask(tb, mode)
.options("-processor", QualifiedClassForProcessing.class.getName())
.options("-processor", QualifiedClassForProcessing.class.getName(),
"--enable-preview",
"-source", Integer.toString(Runtime.version().feature()))
.files(findJavaFiles(src))
.outdir(classes)
.run()