Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262087: Use atomic boolean type in G1FullGCAdjustTask #2664

Closed
wants to merge 1 commit into from
+3 −4
Closed

8262087: Use atomic boolean type in G1FullGCAdjustTask #2664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp
View file
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ class G1AdjustRegionClosure : public HeapRegionClosure {
G1FullGCAdjustTask::G1FullGCAdjustTask(G1FullCollector* collector) :
G1FullGCTask("G1 Adjust", collector),
_root_processor(G1CollectedHeap::heap(), collector->workers()),
_references_done(0),
_references_done(false),
_weak_proc_task(collector->workers()),
_hrclaimer(collector->workers()),
_adjust(collector),
@@ -99,8 +99,7 @@ void G1FullGCAdjustTask::work(uint worker_id) {
marker->preserved_stack()->adjust_during_full_gc();

// Adjust the weak roots.

if (Atomic::add(&_references_done, 1u) == 1u) { // First incr claims task.
if (!Atomic::cmpxchg(&_references_done, false, true)) {
G1CollectedHeap::heap()->ref_processor_stw()->weak_oops_do(&_adjust);
}

2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/g1FullGCAdjustTask.hpp
View file
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ class G1CollectedHeap;

class G1FullGCAdjustTask : public G1FullGCTask {
G1RootProcessor _root_processor;
volatile uint _references_done; // Atomic counter / bool
volatile bool _references_done;
WeakProcessor::Task _weak_proc_task;
HeapRegionClaimer _hrclaimer;
G1AdjustClosure _adjust;