-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261728: SimpleDateFormat should link to DateTimeFormatter #2616
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
/csr |
@naotoj has indicated that a compatibility and specification (CSR) request is needed for this pull request. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Naoto,
Looks good.
Any thoughts to making the new wording stick out more perhaps via a something like "Note: Consider...." and bolding "Note:"
Not sure if it is @APinote worthy but I guess that is an option also?
Good point. Modified. |
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 37 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@naotoj Since your change was applied there have been 51 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 8a1c712. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this simple doc fix. A CSR will be filed accordingly.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2616/head:pull/2616
$ git checkout pull/2616